Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 11103018: .gitignore: Add *.pyc, generated when building as part of ChromiumOS (Closed)

Created:
8 years, 2 months ago by joshtriplett
Modified:
8 years, 2 months ago
CC:
grit-developer_googlegroups.com
Base URL:
https://git.chromium.org/git/external/grit-i18n@master
Visibility:
Public.

Description

.gitignore: Add *.pyc, generated when building as part of ChromiumOS BUG=None TEST=Build Chromium and ChromiumOS from source, and run "repo status", with and without this change. Contributed by Josh Triplett <josh@joshtriplett.org>; Change-Id: Ib13da1002f37404a2e934de0802d3863cae795db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
A .gitignore View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
joshtriplett
8 years, 2 months ago (2012-10-11 00:10:53 UTC) #1
benrg
LGTM. I did this locally and never got around to committing it.
8 years, 2 months ago (2012-10-11 00:13:42 UTC) #2
joshtriplett
On 2012/10/11 00:13:42, benrg wrote: > LGTM. I did this locally and never got around ...
8 years, 2 months ago (2012-10-11 00:38:38 UTC) #3
joshtriplett
OK, I've added an attribution line to the commit message, and I've submitted https://codereview.chromium.org/11092082/ adding ...
8 years, 2 months ago (2012-10-11 18:15:20 UTC) #4
Josh Triplett
8 years, 2 months ago (2012-10-12 19:29:37 UTC) #5
I've reuploaded this change as https://codereview.chromium.org/11121005/ with
the right email address.  benrg, would you mind carrying over your review to
that change, and submitting it as soon as
https://codereview.chromium.org/11121004/ goes in?

Powered by Google App Engine
This is Rietveld 408576698