Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Issue 1110283002: Add pubspec.yaml files for each of the examples/ directories (Closed)

Created:
5 years, 7 months ago by eseidel
Modified:
5 years, 7 months ago
Reviewers:
Hixie
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add pubspec.yaml files for each of the examples/ directories so that pub get will create a packages/ directory for each and users of packages/sky/sky_tool can run these examples from sky_sdk as the instructions say to. TBR=ianh@google.com https://github.com/domokit/mojo/issues/128 Committed: https://chromium.googlesource.com/external/mojo/+/e474b2592ec767480730c7deb4b2e315a35e5df2

Patch Set 1 #

Patch Set 2 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M sky/examples/README.md View 1 chunk +4 lines, -1 line 0 comments Download
A sky/examples/color/pubspec.yaml View 1 chunk +3 lines, -0 lines 0 comments Download
A sky/examples/hello_world/pubspec.yaml View 1 chunk +3 lines, -0 lines 0 comments Download
A sky/examples/raw/pubspec.yaml View 1 chunk +3 lines, -0 lines 0 comments Download
A sky/examples/widgets/pubspec.yaml View 1 1 chunk +3 lines, -0 lines 0 comments Download
M sky/sdk/README.md View 1 1 chunk +14 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eseidel
5 years, 7 months ago (2015-04-28 23:18:18 UTC) #1
eseidel
Committed patchset #2 (id:20001) manually as e474b2592ec767480730c7deb4b2e315a35e5df2 (presubmit successful).
5 years, 7 months ago (2015-04-28 23:26:43 UTC) #2
Hixie
lgtm
5 years, 7 months ago (2015-04-28 23:27:52 UTC) #3
Hixie
5 years, 7 months ago (2015-04-28 23:36:23 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698