Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1110243003: Update Dr. Memory to 1.8.16553 (0xd673826). This fixes problems handling HeapWalk(). (Closed)

Created:
5 years, 7 months ago by Derek Bruening
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang, earthdok
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Dr. Memory to 1.8.16553 (0xd673826). This fixes problems handling HeapWalk(). BUG=481231 TBR=earthdok@chromium.org NOTRY=true Committed: https://crrev.com/646b3185e4958a3ab0676717fe048fd6bf6ebb17 Cr-Commit-Position: refs/heads/master@{#327364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M third_party/drmemory/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/drmemory/drmemory-windows-sfx.exe.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/gtest_exclude/base_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Derek Bruening
5 years, 7 months ago (2015-04-28 20:13:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110243003/1
5 years, 7 months ago (2015-04-28 20:14:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 21:15:37 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/646b3185e4958a3ab0676717fe048fd6bf6ebb17 Cr-Commit-Position: refs/heads/master@{#327364}
5 years, 7 months ago (2015-04-28 21:16:27 UTC) #5
Lei Zhang
There's a lot of red DrMemory bots currently...
5 years, 7 months ago (2015-04-30 07:48:54 UTC) #7
Lei Zhang
5 years, 7 months ago (2015-05-01 21:00:44 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1117123003/ by thestig@chromium.org.

The reason for reverting is: Turned all the DrMemory bots red..

Powered by Google App Engine
This is Rietveld 408576698