Update list markers in notify change.

Source/core/layout/LayoutListItem.cpp

Index: Source/core/layout/LayoutListItem.cpp
diff --git a/Source/core/layout/LayoutListItem.cpp b/Source/core/layout/LayoutListItem.cpp
index 96fddad21f98b5e09296f7d48fb5d85253be63e7..ca04e941de8bc74dab73f73844cd18d5c12d2cb8 100644
--- a/Source/core/layout/LayoutListItem.cpp
+++ b/Source/core/layout/LayoutListItem.cpp
@@ -29,7 +29,6 @@
 #include "core/html/HTMLOListElement.h"
 #include "core/layout/LayoutListMarker.h"
 #include "core/layout/LayoutView.h"
-#include "core/layout/TextAutosizer.h"
 #include "wtf/StdLibExtras.h"
 #include "wtf/text/StringBuilder.h"
 
@@ -45,6 +44,9 @@ LayoutListItem::LayoutListItem(Element* element)
     , m_notInList(false)
 {
     setInline(false);
+    setConsumesSubtreeChangeNotification();
+    setAncestorNeedsSubtreeChangeNotification(true);
+    setNeedsSubtreeChangeNotification();
 }
 
 void LayoutListItem::styleDidChange(StyleDifference diff, const ComputedStyle* oldStyle)
@@ -56,6 +58,7 @@ void LayoutListItem::styleDidChange(StyleDifference diff, const ComputedStyle* o
         if (!m_marker)
             m_marker = LayoutListMarker::createAnonymous(this);
         m_marker->listItemStyleDidChange();
+        setNeedsSubtreeChangeNotification();
     } else if (m_marker) {
         m_marker->destroy();
         m_marker = nullptr;
@@ -85,6 +88,20 @@ void LayoutListItem::willBeRemovedFromTree()
     updateListMarkerNumbers();
 }
 
+void LayoutListItem::subtreeDidChange()
+{
+    if (!m_marker)
+        return;
+
+    if (!updateMarkerLocation())
+        return;
+
+    // If the marker is inside we need to redo the preferred width calculations
+    // as the size of the item now includes the size of the list marker.
+    if (m_marker->isInside())
+        containingBlock()->setPreferredLogicalWidthsDirty();

[ojan, 2015/04/30 02:56:45]

I'm not 100% sure, but I think you want to setPreferredLogicalWidthsDirty() on
the LayoutListItem itself since it's the preferred width of the list item itself
that changes. That will mark up the tree appropriately.

[dsinclair, 2015/04/30 17:52:29]

Done. This was copied from the original code which used containingBlock instead
of the ListItem.

+}
+
 static bool isList(const Node& node)
 {
     return isHTMLUListElement(node) || isHTMLOListElement(node);
@@ -265,38 +282,10 @@ static LayoutObject* firstNonMarkerChild(LayoutObject* parent)
     return result;
 }
 
-void LayoutListItem::updateMarkerLocationAndInvalidateWidth()
-{
-    ASSERT(m_marker);
-
-    // FIXME: We should not modify the structure of the render tree
-    // during layout. crbug.com/370461
-    DeprecatedDisableModifyLayoutTreeStructureAsserts disabler;
-    LayoutState* layoutState = view()->layoutState();
-    LayoutFlowThread* currentFlowThread = nullptr;
-    if (layoutState) {
-        // We're about to modify the layout tree structure (during layout!), and any code using
-        // LayoutState might get utterly confused by that. There's no evidence that anything other
-        // than the flow thread code will suffer, though, so just reset the current flow thread
-        // temporarily.
-        // FIXME: get rid of this hack, including the flow thread setter in LayoutState, as part of
-        // fixing crbug.com/370461
-        currentFlowThread = layoutState->flowThread();
-        layoutState->setFlowThread(nullptr);
-    }
-    if (updateMarkerLocation()) {
-        // If the marker is inside we need to redo the preferred width calculations
-        // as the size of the item now includes the size of the list marker.
-        if (m_marker->isInside())
-            containingBlock()->updateLogicalWidth();
-    }
-    if (layoutState)
-        layoutState->setFlowThread(currentFlowThread);
-}
-
 bool LayoutListItem::updateMarkerLocation()
 {
     ASSERT(m_marker);
+
     LayoutObject* markerParent = m_marker->parent();
     LayoutObject* lineBoxParent = getParentOfFirstLineBox(this, m_marker);
     if (!lineBoxParent) {
@@ -322,23 +311,6 @@ bool LayoutListItem::updateMarkerLocation()
     return false;
 }
 
-void LayoutListItem::layout()
-{
-    ASSERT(needsLayout());
-
-    if (m_marker) {
-        // The marker must be autosized before calling
-        // updateMarkerLocationAndInvalidateWidth. It cannot be done in the
-        // parent's beginLayout because it is not yet in the render tree.
-        if (TextAutosizer* textAutosizer = document().textAutosizer())
-            textAutosizer->inflateListItem(this, m_marker);
-
-        updateMarkerLocationAndInvalidateWidth();
-    }
-
-    LayoutBlockFlow::layout();
-}
-
 void LayoutListItem::addOverflowFromChildren()
 {
     LayoutBlockFlow::addOverflowFromChildren();
@@ -489,8 +461,7 @@ void LayoutListItem::clearExplicitValue()
 void LayoutListItem::setNotInList(bool notInList)
 {
     m_notInList = notInList;
-    if (m_marker)
-        updateMarkerLocation();
+    setNeedsSubtreeChangeNotification();

[ojan, 2015/04/30 02:56:45]

Since we set this in the constructor, do we need to call this here? I only see
one caller of this function and that's inside attach, where were should have
just created the LayoutListItem.

[dsinclair, 2015/04/30 17:52:30]

Good catch. Done.

 }
 
 static LayoutListItem* previousOrNextItem(bool isListReversed, Node* list, LayoutListItem* item)