Source/modules/notifications/Notification.cpp - Issue 1110223002: Use and add layout tests for BCP 47 language tag syntax validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/Notification.cpp

Issue 1110223002: Use and add layout tests for BCP 47 language tag syntax validation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/notifications/Notification.cpp

diff --git a/Source/modules/notifications/Notification.cpp b/Source/modules/notifications/Notification.cpp

index 227238ee3de57445545df040d126cc92a36323a5..a2d4c6f7bf8680f4ce306d15415779559fd813ef 100644

--- a/Source/modules/notifications/Notification.cpp

+++ b/Source/modules/notifications/Notification.cpp

@@ -96,7 +96,10 @@ Notification* Notification::create(ExecutionContext* context, const String& titl

notification->setBody(options.body());

notification->setTag(options.tag());

- notification->setLang(options.lang());

+ if (Platform::current()->isValidLocaleSyntax(options.lang()))

+ notification->setLang(options.lang());

notification->setDir(options.dir());

notification->setVibrate(NavigatorVibration::sanitizeVibrationPattern(options.vibrate()));

notification->setSilent(options.silent());