Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1110193004: Build Chromium Mojo unittests on CQ and main waterfall GN bots. (Closed)

Created:
5 years, 7 months ago by msw
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build Chromium Mojo unittests on CQ and main waterfall GN bots. Build (but don't run) new test targets on the following bots: chromium.linux "Linux GN" chromium.linux "Linux GN (dbg)" tryserver.chromium.linux "linux_chromium_gn_chromeos_dbg" tryserver.chromium.linux "linux_chromium_gn_chromeos_rel" tryserver.chromium.linux "linux_chromium_gn_dbg" tryserver.chromium.linux "linux_chromium_gn_rel" Add targets to each supported bot: html_viewer_unittests (release only, no debug component builds) mojo_runner_unittests (release only, no debug component builds) mojo_shell_unittests mojo_surfaces_lib_unittests view_manager_service_unittests (release only, no debug component builds) These match the Chromium Mojo FYI waterfall unittest targets: https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/recipes/chromium_mojo.py BUG=478244 TEST=CQ and main waterfall GN bots build new test targets. R=sky@chromium.org,dpranke@chromium.org Committed: https://crrev.com/4c7c42a264c1537507ee1beb86c2d81fae68cb80 Cr-Commit-Position: refs/heads/master@{#327454}

Patch Set 1 #

Patch Set 2 : Remove deleted window_manager_unittests target. #

Patch Set 3 : Remove deleted mojo_application_manager_unittests target. #

Patch Set 4 : Skip html_viewer_unittests on dbg bots, target isn't defined for is_component_build=true. #

Patch Set 5 : Skip mojo_runner_unittests on component dbg builds too. #

Patch Set 6 : Ditto for vm unittests. #

Patch Set 7 : And mojo_shell_unittests... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M testing/buildbot/chromium.linux.json View 1 2 3 4 5 6 4 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/tryserver.chromium.linux.json View 1 2 3 4 5 6 8 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110193004/1
5 years, 7 months ago (2015-04-28 22:37:12 UTC) #2
msw
Hey Scott and Dirk, please take a look; thanks!
5 years, 7 months ago (2015-04-28 22:38:14 UTC) #4
Dirk Pranke
lgtm. I'm starting to add tests to the bots (particularly the waterfall bots), and I ...
5 years, 7 months ago (2015-04-28 22:43:15 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/32201) linux_chromium_gn_dbg on ...
5 years, 7 months ago (2015-04-28 22:47:06 UTC) #7
msw
On 2015/04/28 22:43:15, Dirk Pranke wrote: > lgtm. > > I'm starting to add tests ...
5 years, 7 months ago (2015-04-28 22:48:04 UTC) #8
Dirk Pranke
On 2015/04/28 22:48:04, msw wrote: > On FYI, Linux is now green, and Android passes ...
5 years, 7 months ago (2015-04-28 22:51:39 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110193004/20001
5 years, 7 months ago (2015-04-28 22:52:19 UTC) #12
msw
On 2015/04/28 22:51:39, Dirk Pranke wrote: > On 2015/04/28 22:48:04, msw wrote: > > On ...
5 years, 7 months ago (2015-04-28 22:59:44 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/32213) linux_chromium_gn_dbg on ...
5 years, 7 months ago (2015-04-28 23:02:21 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110193004/40001
5 years, 7 months ago (2015-04-28 23:10:05 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/66557)
5 years, 7 months ago (2015-04-28 23:23:20 UTC) #20
sky
LGTM
5 years, 7 months ago (2015-04-28 23:37:23 UTC) #21
msw
I removed html_viewer_unittests from the debug bots, it doesn't support is_component_build=true.
5 years, 7 months ago (2015-04-29 02:56:30 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110193004/60001
5 years, 7 months ago (2015-04-29 02:58:00 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/66629)
5 years, 7 months ago (2015-04-29 03:07:38 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110193004/120001
5 years, 7 months ago (2015-04-29 06:00:32 UTC) #30
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 7 months ago (2015-04-29 09:12:33 UTC) #31
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 09:13:30 UTC) #32
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/4c7c42a264c1537507ee1beb86c2d81fae68cb80
Cr-Commit-Position: refs/heads/master@{#327454}

Powered by Google App Engine
This is Rietveld 408576698