Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1110183004: cc: Get BeginFrameArgs for STP::BeginMainFrame while inside an impl frame. (Closed)

Created:
5 years, 7 months ago by mithro-old
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Get BeginFrameArgs for BeginMainFrame while inside an impl frame. This patch also adds asserts to make sure that the assumption that ScheduledActionSendBeginMainFrame is only called inside an impl frame holds. Sending a BeginMainFrame requires BeginFrameArgs to be read from the LTHI which are only valid inside an impl frame. Due to needing to call BeginMainFrame asynchronously (as the comment inside the function mentions), the call could theoretically occur outside an impl frame. The likelihood of this effecting production is extremely low because impl frames are large but this problem does increase flakiness of the layer tree host unittests. BUG=346230 R=brianderson,enne Committed: https://crrev.com/69fd3bb5a6824436bb7c3f5905dc3ab3051b9d3b Cr-Commit-Position: refs/heads/master@{#327874}

Patch Set 1 #

Patch Set 2 : Rebase onto master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M cc/trees/single_thread_proxy.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 5 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mithro-old
Hi Brian / Enne, This is another patch related to trying to test https://codereview.chromium.org/1099703004/. At ...
5 years, 7 months ago (2015-04-29 01:13:32 UTC) #1
sunnyps
LGTM
5 years, 7 months ago (2015-05-01 00:58:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110183004/20001
5 years, 7 months ago (2015-05-01 02:54:28 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-01 03:45:11 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-01 03:46:04 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/69fd3bb5a6824436bb7c3f5905dc3ab3051b9d3b
Cr-Commit-Position: refs/heads/master@{#327874}

Powered by Google App Engine
This is Rietveld 408576698