gm/convex_all_line_paths.cpp - Issue 1110153002: Fix memory deletion error in "convex-lineonly-paths" GM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/convex_all_line_paths.cpp

Issue 1110153002: Fix memory deletion error in "convex-lineonly-paths" GM (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/convex_all_line_paths.cpp

diff --git a/gm/convex_all_line_paths.cpp b/gm/convex_all_line_paths.cpp

index d56325b7dba6c0f9eb115c0f1cca3cd3ee541e05..0ffd65497cbf08ff910724f0917d0c09d50bd132 100644

--- a/gm/convex_all_line_paths.cpp

+++ b/gm/convex_all_line_paths.cpp

@@ -165,7 +165,7 @@ protected:

};

SK_COMPILE_ASSERT(SK_ARRAY_COUNT(gSizes) == SK_ARRAY_COUNT(gPoints), array_mismatch);

- SkAutoTDelete<SkPoint> data;

+ SkAutoTDeleteArray<SkPoint> data(NULL);

const SkPoint* points;

int numPts;

if (index < (int) SK_ARRAY_COUNT(gPoints)) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »