[iOS] Upstream code in //ios/chrome/app

[iOS] Upstream code in //ios/chrome/app

Committed: https://crrev.com/e7d6799e93c88c89906f59d16b23711d24e04b29
Cr-Commit-Position: refs/heads/master@{#327462}

[droger, 2015-04-28 14:36:41]

Patchset #1 (id:1) has been deleted

[droger, 2015-04-28 14:38:00]

Patchset #1 (id:20001) has been deleted

[droger, 2015-04-28 14:38:30]

droger@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2015-04-28 14:57:25]

https://codereview.chromium.org/1110133002/diff/40001/ios/chrome/app/OWNERS
File ios/chrome/app/OWNERS (right):

https://codereview.chromium.org/1110133002/diff/40001/ios/chrome/app/OWNERS#n...
ios/chrome/app/OWNERS:1: stuartmorgan@chromium.org
nit: remove this file, stuartmorgan@ is already OWNERS of //ios

https://codereview.chromium.org/1110133002/diff/40001/ios/chrome/app/UIApplic...
File ios/chrome/app/UIApplication+ExitsOnSuspend.h (right):

https://codereview.chromium.org/1110133002/diff/40001/ios/chrome/app/UIApplic...
ios/chrome/app/UIApplication+ExitsOnSuspend.h:8: #if !defined(NDEBUG)
Why !defined(NDEBUG) instead of !defined(GOOGLE_CHROME_BUILD)?

https://codereview.chromium.org/1110133002/diff/40001/ios/chrome/app/UIApplic...
File ios/chrome/app/UIApplication+ExitsOnSuspend.mm (right):

https://codereview.chromium.org/1110133002/diff/40001/ios/chrome/app/UIApplic...
ios/chrome/app/UIApplication+ExitsOnSuspend.mm:40: if (identifier !=
UIBackgroundTaskInvalid)
nit: please use {} as the code in if is complex

https://codereview.chromium.org/1110133002/diff/40001/ios/chrome/app/deferred...
File ios/chrome/app/deferred_initialization_runner.mm (right):

https://codereview.chromium.org/1110133002/diff/40001/ios/chrome/app/deferred...
ios/chrome/app/deferred_initialization_runner.mm:12: -
(NSUInteger)numberOfBlocksRemaining;
nit: this could be a readonly property

https://codereview.chromium.org/1110133002/diff/40001/ios/chrome/app/deferred...
ios/chrome/app/deferred_initialization_runner.mm:18: @private
nit: I think @private can be removed here since the ivar are declared in the
implementation file

https://codereview.chromium.org/1110133002/diff/40001/ios/chrome/app/deferred...
ios/chrome/app/deferred_initialization_runner.mm:80: @private
nit: idem, @private can be removed

[sdefresne, 2015-04-28 14:57:45]

lgtm to unblock you since I only put nits

[droger, 2015-04-29 08:53:25]

All done, except the change to !defined(NDEBUG)

https://codereview.chromium.org/1110133002/diff/40001/ios/chrome/app/UIApplic...
File ios/chrome/app/UIApplication+ExitsOnSuspend.h (right):

https://codereview.chromium.org/1110133002/diff/40001/ios/chrome/app/UIApplic...
ios/chrome/app/UIApplication+ExitsOnSuspend.h:8: #if !defined(NDEBUG)
On 2015/04/28 14:57:25, sdefresne wrote:
> Why !defined(NDEBUG) instead of !defined(GOOGLE_CHROME_BUILD)?

I don't know, I'd like to not change this as part of upstreaming.

https://codereview.chromium.org/1110133002/diff/40001/ios/chrome/app/deferred...
File ios/chrome/app/deferred_initialization_runner.mm (right):

https://codereview.chromium.org/1110133002/diff/40001/ios/chrome/app/deferred...
ios/chrome/app/deferred_initialization_runner.mm:12: -
(NSUInteger)numberOfBlocksRemaining;
On 2015/04/28 14:57:25, sdefresne wrote:
> nit: this could be a readonly property

I removed the code, it's not used.

[droger, 2015-04-29 08:54:02]

The CQ bit was checked by droger@chromium.org

[droger, 2015-04-29 08:54:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/1110133002/#ps60001
(title: "Review comments")

[commit-bot: I haz the power, 2015-04-29 08:54:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1110133002/60001

[commit-bot: I haz the power, 2015-04-29 09:56:36]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-04-29 09:57:34]

Patchset 2 (id:??) landed as
https://crrev.com/e7d6799e93c88c89906f59d16b23711d24e04b29
Cr-Commit-Position: refs/heads/master@{#327462}