Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1110123002: Add bsvc.dll to Chrome's Browser's Blacklist (Closed)

Created:
5 years, 7 months ago by csharp
Modified:
5 years, 7 months ago
Reviewers:
Cait (Slow), jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org, caitkp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add bsvc.dll to Chrome's Browser's Blacklist Also add two older values to dllhash. BUG= Committed: https://crrev.com/056966e85df9d132d6ff8bcc5f68ad0eef7750e2 Cr-Commit-Position: refs/heads/master@{#327295}

Patch Set 1 #

Patch Set 2 : Adding two values to dllhash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome_elf/blacklist/blacklist.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
csharp
caitkp@ to review blacklist.cc jwd@ to review histograms.xml
5 years, 7 months ago (2015-04-28 14:24:07 UTC) #2
jwd
lgtm
5 years, 7 months ago (2015-04-28 14:39:16 UTC) #3
Cait (Slow)
blacklist.cc lgtm
5 years, 7 months ago (2015-04-28 14:39:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110123002/20001
5 years, 7 months ago (2015-04-28 15:00:38 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-28 16:03:22 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 16:04:16 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/056966e85df9d132d6ff8bcc5f68ad0eef7750e2
Cr-Commit-Position: refs/heads/master@{#327295}

Powered by Google App Engine
This is Rietveld 408576698