Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1110103004: Hook up Android closed captions 'enabled' setting to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Setting an enum value instead of passing down boolean to Blink Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 094ebe88c06436458f2a162326fd408e02c635ef..1b25e9d4e5a8e7bb8125bf6604b2db98fde9238a 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -220,6 +220,7 @@ using blink::WebSecurityOrigin;
using blink::WebSecurityPolicy;
using blink::WebSerializedScriptValue;
using blink::WebServiceWorkerProvider;
+using blink::WebSettings;
using blink::WebStorageQuotaCallbacks;
using blink::WebString;
using blink::WebURL;
@@ -1574,6 +1575,13 @@ void RenderFrameImpl::OnTextTrackSettingsChanged(
DCHECK(!frame_->parent());
if (!render_view_->webview())
return;
+
+ if (params.text_tracks_enabled)
David Trainor- moved to gerrit 2015/07/09 21:46:47 I'm not sure, but does the styleguide require {} i
+ render_view_->webview()->settings()->setTextTrackKindUserPreference(
+ WebSettings::TextTrackKindUserPreference::Captions);
+ else
+ render_view_->webview()->settings()->setTextTrackKindUserPreference(
+ WebSettings::TextTrackKindUserPreference::Default);
render_view_->webview()->settings()->setTextTrackBackgroundColor(
WebString::fromUTF8(params.text_track_background_color));
render_view_->webview()->settings()->setTextTrackFontFamily(

Powered by Google App Engine
This is Rietveld 408576698