Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 1110103004: Hook up Android closed captions 'enabled' setting to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Setting an enum value instead of passing down boolean to Blink Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index a7fb902ecc09f421a09ee70d085c764b18abec79..638d0c9c6f02e267d4440bb9e421cc6b1edd821f 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -1280,6 +1280,7 @@ void ContentViewCoreImpl::SetAccessibilityEnabled(JNIEnv* env, jobject obj,
void ContentViewCoreImpl::SetTextTrackSettings(JNIEnv* env,
jobject obj,
+ jboolean textTracksEnabled,
jstring textTrackBackgroundColor,
jstring textTrackFontFamily,
jstring textTrackFontStyle,
@@ -1288,6 +1289,7 @@ void ContentViewCoreImpl::SetTextTrackSettings(JNIEnv* env,
jstring textTrackTextShadow,
jstring textTrackTextSize) {
FrameMsg_TextTrackSettings_Params params;
+ params.text_tracks_enabled = textTracksEnabled;
params.text_track_background_color = ConvertJavaStringToUTF8(
env, textTrackBackgroundColor);
params.text_track_font_family = ConvertJavaStringToUTF8(
@@ -1303,7 +1305,8 @@ void ContentViewCoreImpl::SetTextTrackSettings(JNIEnv* env,
params.text_track_text_size = ConvertJavaStringToUTF8(
env, textTrackTextSize);
- web_contents_->GetMainFrame()->SetTextTrackSettings(params);
+ if (web_contents_)
David Trainor- moved to gerrit 2015/07/09 21:46:47 I don't think this can ever be null.
+ web_contents_->GetMainFrame()->SetTextTrackSettings(params);
}
bool ContentViewCoreImpl::IsFullscreenRequiredForOrientationLock() const {

Powered by Google App Engine
This is Rietveld 408576698