content/renderer/service_worker/embedded_worker_context_client.h - Issue 1110103003: Initial implementation of stashed message ports, content side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/embedded_worker_context_client.h

Issue 1110103003: Initial implementation of stashed message ports, content side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/message_port_delegate.h ('K') | « content/public/browser/message_port_delegate.h ('k') | content/renderer/service_worker/embedded_worker_context_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/embedded_worker_context_client.h

diff --git a/content/renderer/service_worker/embedded_worker_context_client.h b/content/renderer/service_worker/embedded_worker_context_client.h

index 248591ec908f8480d035475b756047dbde1ab3e2..c0c71d061ccd0b400a202adacfab147c67cc6168 100644

--- a/content/renderer/service_worker/embedded_worker_context_client.h

+++ b/content/renderer/service_worker/embedded_worker_context_client.h

@@ -126,6 +126,8 @@ class EmbeddedWorkerContextClient

virtual void skipWaiting(

blink::WebServiceWorkerSkipWaitingCallbacks* callbacks);

virtual void claim(blink::WebServiceWorkerClientsClaimCallbacks* callbacks);

+ virtual void stashMessagePort(blink::WebMessagePortChannel* channel,

+ const blink::WebString& name) override;

nhiroki 2015/05/18 04:45:57 nit: You don't have to add "virtual" if you use "o

Marijn Kruisselbrink 2015/05/18 22:19:36 Yes, of course. Although I should probably remove

kinuko 2015/05/19 09:01:45 Let's not add override until after the blink repo

// TODO: Implement DevTools related method overrides.