Avoid using SkPathEffect::DashInfo in GrStrokeInfo

Avoid using SkPathEffect::DashInfo in GrStrokeInfo

Avoid using SkPathEffect::DashInfo for storing the phase 
in GrStrokeInfo. Instead, just use normal instance variables.

Fixes the copy constructor pointing the DashInfo interval pointer
to the wrong interval data.

Also fixes GrStrokeInfo::setDashInfo(const SkPathEffect::DashInfo&)
by updating the fDashType correctly.
    
Makes it simpler to write code such as the operator== in the future.

Committed: https://skia.googlesource.com/skia/+/261694c98a4de4c67fb719e365c0345da0473a17

[Kimmo Kinnunen, 2015-04-28 08:57:44]

kkinnunen@nvidia.com changed reviewers:
+ egdaniel@google.com

[egdaniel, 2015-04-28 14:45:29]

just a couple nits

https://codereview.chromium.org/1110093002/diff/20001/src/gpu/GrStrokeInfo.h
File src/gpu/GrStrokeInfo.h (right):

https://codereview.chromium.org/1110093002/diff/20001/src/gpu/GrStrokeInfo.h#...
src/gpu/GrStrokeInfo.h:17: * width, miter, cap, and join. The second object is
DashInfo. This holds information about the
update comment

https://codereview.chromium.org/1110093002/diff/20001/src/gpu/GrStrokeInfo.h#...
src/gpu/GrStrokeInfo.h:67: * This functions takes in a patheffect and fills in
fDashInfo with the various dashing
update comment

[Kimmo Kinnunen, 2015-05-04 06:08:07]

Thanks. How about now?

https://codereview.chromium.org/1110093002/diff/20001/src/gpu/GrStrokeInfo.h
File src/gpu/GrStrokeInfo.h (right):

https://codereview.chromium.org/1110093002/diff/20001/src/gpu/GrStrokeInfo.h#...
src/gpu/GrStrokeInfo.h:17: * width, miter, cap, and join. The second object is
DashInfo. This holds information about the
On 2015/04/28 14:45:29, egdaniel wrote:
> update comment

Done.

https://codereview.chromium.org/1110093002/diff/20001/src/gpu/GrStrokeInfo.h#...
src/gpu/GrStrokeInfo.h:67: * This functions takes in a patheffect and fills in
fDashInfo with the various dashing
On 2015/04/28 14:45:29, egdaniel wrote:
> update comment

Done.

[egdaniel, 2015-05-04 13:23:34]

lgtm

[Kimmo Kinnunen, 2015-05-05 06:02:08]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2015-05-05 06:02:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1110093002/60001

[commit-bot: I haz the power, 2015-05-05 15:00:16]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/261694c98a4de4c67fb719e365c0345da0473a17