Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1110063006: Revert "Correct fixed-position recording for Slimming Paint" (Closed)

Created:
5 years, 7 months ago by Stephen White
Modified:
5 years, 7 months ago
CC:
blink-reviews, krit, blink-reviews-rendering, Rik, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, slimming-paint-reviews_chromium.org, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Justin Novosad, jchaffraix+rendering, blink-reviews-paint_chromium.org, dshwang, Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert "Correct fixed-position recording for Slimming Paint" This reverts commit 3dcda01acfbd9732987c491e8642491a2b1f7857, aka r194643. Seems to be causing asserts to fire on Linux ChromiumOS Tests (dbg): http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/1485 This is a speculative revert: if the bots don't green up, I'll revert this. TBR=trchen@chromium.org,chrishtr@chromium.org,achuith@chromium.org,nkostylev@chromium.org BUG=482170 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194664

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -386 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +1 line, -6 lines 0 comments Download
D LayoutTests/paint/overflow/fixed-children-should-not-scroll.html View 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/paint/overflow/fixed-children-should-not-scroll-expected.html View 1 chunk +0 lines, -23 lines 0 comments Download
M LayoutTests/platform/linux/virtual/slimmingpaint/fast/layers/scroll-descendant-with-cached-cliprects-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/platform/linux/virtual/slimmingpaint/fast/repaint/position-change-keeping-geometry-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/virtual/slimmingpaint/fast/repaint/position-change-keeping-geometry-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/slimmingpaint/fast/layers/scroll-descendant-with-cached-cliprects-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/virtual/slimmingpaint/fast/repaint/absolute-position-change-containing-block-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/slimmingpaint/fast/repaint/fixed-after-scroll-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/slimmingpaint/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/virtual/slimmingpaint/fast/repaint/position-change-keeping-geometry-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/layout/LayoutObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerPainter.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
D Source/core/paint/LayerFixedPositionRecorder.h View 1 chunk +0 lines, -30 lines 0 comments Download
D Source/core/paint/LayerFixedPositionRecorder.cpp View 1 chunk +0 lines, -54 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/platform/graphics/paint/DisplayItem.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/platform/graphics/paint/DisplayItem.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
D Source/platform/graphics/paint/FixedPositionContainerDisplayItem.h View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/platform/graphics/paint/FixedPositionContainerDisplayItem.cpp View 1 chunk +0 lines, -24 lines 0 comments Download
D Source/platform/graphics/paint/FixedPositionDisplayItem.h View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/platform/graphics/paint/FixedPositionDisplayItem.cpp View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110063006/1
5 years, 7 months ago (2015-04-29 16:31:49 UTC) #2
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 16:37:05 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194664

Powered by Google App Engine
This is Rietveld 408576698