[sync] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle

sync/internal_api/public/util/weak_handle.h

Index: sync/internal_api/public/util/weak_handle.h
diff --git a/sync/internal_api/public/util/weak_handle.h b/sync/internal_api/public/util/weak_handle.h
index c299be719c9f63ee5680b6525b1b57f2abbb1eb0..c6f1504069a3f083eee81703bfe9edf9077e4358 100644
--- a/sync/internal_api/public/util/weak_handle.h
+++ b/sync/internal_api/public/util/weak_handle.h
@@ -58,10 +58,12 @@
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
+#include "base/single_thread_task_runner.h"
+#include "base/thread_task_runner_handle.h"

[maniscalco, 2015/04/28 18:27:29]

Is this include needed?

[anujsharma, 2015/04/29 05:08:05]

Removed!!

 #include "sync/base/sync_export.h"
 
 namespace base {
-class MessageLoopProxy;
+class SingleThreadTaskRunner;

[maniscalco, 2015/04/28 18:27:29]

Given this forward declaration, is the include for single_thread_task_runner.h
necessary in this file?

[anujsharma, 2015/04/29 05:08:05]

Yes, it is required.

[maniscalco, 2015/04/29 15:23:16]

Cool, since we're including the header you should be able to remove the forward
declaration.  You generally want only one or the other, not both.

 }  // namespace base
 
 namespace tracked_objects {
@@ -118,7 +120,7 @@ class SYNC_EXPORT WeakHandleCoreBase {
 
  private:
   // May be used on any thread.
-  const scoped_refptr<base::MessageLoopProxy> owner_loop_proxy_;
+  const scoped_refptr<base::SingleThreadTaskRunner> owner_loop_proxy_;

[maniscalco, 2015/04/28 18:27:29]

How about renaming to owner_loop_task_runner_ ?

[anujsharma, 2015/04/29 05:08:05]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(WeakHandleCoreBase);
 };