Change vibrate type in WebNotificationData

Change vibrate type in WebNotificationData

The vibrate data type is unsigned in blink, but this is clamped
through kVibrationDurationMax. so, it is also fine to use an integer type.

BUG=442132
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194596

[Sanghyun Park, 2015-04-28 07:00:07]

sh919.park@samsung.com changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2015-04-28 11:06:53]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2015-04-28 11:06:54]

lgtm

[commit-bot: I haz the power, 2015-04-28 11:07:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1110063002/1

[Peter Beverloo, 2015-04-28 11:08:39]

The CQ bit was unchecked by peter@chromium.org

[Peter Beverloo, 2015-04-28 11:09:47]

Sorry, wrong button :-(

Won't this cause a whole bunch of unsigned -> signed implicit conversion
warnings within Blink compilation?

[Sanghyun Park, 2015-04-28 11:37:39]

On 2015/04/28 11:09:47, Peter Beverloo wrote:
> Sorry, wrong button :-(
> 
> Won't this cause a whole bunch of unsigned -> signed implicit conversion
> warnings within Blink compilation?

Hi Peter.

In initializeFrom() method on WebVector.h,  unsigned  -> static_cast<char*> ->
copy data -> reinterpret_cast signed int.
It seems to be no problem.

WDYT?

[Peter Beverloo, 2015-04-28 11:42:26]

On 2015/04/28 11:37:39, Sanghyun Park wrote:
> On 2015/04/28 11:09:47, Peter Beverloo wrote:
> > Sorry, wrong button :-(
> > 
> > Won't this cause a whole bunch of unsigned -> signed implicit conversion
> > warnings within Blink compilation?
> 
> Hi Peter.
> 
> In initializeFrom() method on WebVector.h,  unsigned  -> static_cast<char*> ->
> copy data -> reinterpret_cast signed int.
> It seems to be no problem.
> 
> WDYT?

Hmm ok. Let's make sure the bots are happy.

[Sanghyun Park, 2015-04-28 11:46:47]

On 2015/04/28 11:42:26, Peter Beverloo wrote:
> On 2015/04/28 11:37:39, Sanghyun Park wrote:
> > On 2015/04/28 11:09:47, Peter Beverloo wrote:
> > > Sorry, wrong button :-(
> > > 
> > > Won't this cause a whole bunch of unsigned -> signed implicit conversion
> > > warnings within Blink compilation?
> > 
> > Hi Peter.
> > 
> > In initializeFrom() method on WebVector.h,  unsigned  -> static_cast<char*>
-> 
> > copy data -> reinterpret_cast signed int.
> > It seems to be no problem.
> > 
> > WDYT?
> 
> Hmm ok. Let's make sure the bots are happy.

Sure, Thanks :)

[Peter Beverloo, 2015-04-28 12:34:06]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2015-04-28 12:34:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1110063002/1

[commit-bot: I haz the power, 2015-04-28 12:34:51]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194596