Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1110013002: Update more directories under src/ to follow C++11 style rule for {virtual,override}. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update more directories under src/ to follow C++11 style rule for {virtual,override}. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. The entries were found using the following command line: $ find src/ -iname "*.h" -o -iname "*.cpp" | xargs pcregrep -M "[^\n/]+virtual\ [^;{]+\ [a-zA-Z0-9_]+\([^;{]+\ override[ \n]*[;{]" The regex was a courtesy of nick@chromium.org BUG=None R=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/f4219ddf31b2171a5576ab98d1fd2deab4d816fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M src/animator/SkDisplayMath.h View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDisplayTypes.h View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDraw3D.h View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDrawPaint.h View 1 chunk +1 line, -1 line 0 comments Download
M src/doc/SkDocument_PDF.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/doc/SkDocument_XPS.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/pdf/SkPDFStream.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/pdf/SkPDFTypes.h View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110013002/1
5 years, 7 months ago (2015-04-27 23:14:30 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-27 23:20:06 UTC) #4
tfarina
5 years, 7 months ago (2015-04-27 23:33:09 UTC) #5
mtklein
lgtm
5 years, 7 months ago (2015-04-28 00:17:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1110013002/1
5 years, 7 months ago (2015-04-28 00:18:12 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 00:18:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f4219ddf31b2171a5576ab98d1fd2deab4d816fd

Powered by Google App Engine
This is Rietveld 408576698