Issue 1110003: create consent file for official builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1110003: create consent file for official builds (Closed)

Created:
10 years, 9 months ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
djmm

CC:
chromium-os-reviews_chromium.org, Chris Masone

Visibility:
Public.

Description

create consent file for official builds Once we get /etc/send_metrics in place on official builds, this change will notice and auto-create the consent file for metrics if it doesn't exist. BUG=cros:1865 TEST=boot chromium os without /etc/send_metrics, see that no consent file is created. create /etc/send_metrics and reboot...the consent file should now be present.

Patch Set 1 #

Total comments: 2

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	session_manager_setup.sh	View		2 chunks	+11 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

djmm

http://codereview.chromium.org/1110003/diff/1/2 File session_manager_setup.sh (right): http://codereview.chromium.org/1110003/diff/1/2#newcode71 session_manager_setup.sh:71: CONSENT_FILE="$DATA_DIR/Consent To Send Stats" Filename with spaces?

10 years, 9 months ago (2010-03-18 19:48:53 UTC) #2

Chris Masone

10 years, 9 months ago (2010-03-18 19:57:07 UTC) #3

djmm

10 years, 9 months ago (2010-03-18 20:09:16 UTC) #4

On 2010/03/18 19:57:07, cmasone wrote:
> http://codereview.chromium.org/1110003/diff/1/2
> File session_manager_setup.sh (right):
> 
> http://codereview.chromium.org/1110003/diff/1/2#newcode71
> session_manager_setup.sh:71: CONSENT_FILE="$DATA_DIR/Consent To Send Stats"
> On 2010/03/18 19:48:53, djmm wrote:
> > Filename with spaces? 
> 
> Yup.
> 
> That's what Chrome expects.

Ah ok.  Ewww, but LGTM.

Expand Messages | Collapse Messages