Better support ChromeVox list and list-like output.

Better support ChromeVox list and list-like output.

With the 'enter' rule, we can simplify the output of list-like roles. Namely, ChromeVox can generalize its treatment of saying, x role with y items for a variety of roles.

BUG=481583
TEST=chromevox_tests --gtest_filter=OutputE2ETest.*

Committed: https://crrev.com/5ed119b3af7ab4322e6f36adccbc67680b012857
Cr-Commit-Position: refs/heads/master@{#327362}

[David Tseng, 2015-04-27 22:53:44]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2015-04-27 22:59:21]

lgtm

Could you do the same for other list-like roles as part of this change too?

list_box -> list_box_option
menu_list_popup -> menu_list_option
tree -> tree_item
menu -> menu_item

[David Tseng, 2015-04-28 18:43:06]

PTAL. Added the suggested roles and updated the description to better reflect
this cl.

[dmazzoni, 2015-04-28 18:47:40]

https://codereview.chromium.org/1109983003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
(right):

https://codereview.chromium.org/1109983003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:250:
enter: '$role'
Should this one have describe_index too?

https://codereview.chromium.org/1109983003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:260:
menuListOption: {
Please add menuList also - it's <select> without multiple.

It will have one child, a menuListPopup, which will have menuListOption
children.

[David Tseng, 2015-04-28 19:06:33]

I'm not seeing menuList in the tree. I'm seeing the following ancestry chain
menuListOption < menuListPopup < PopupButton

https://codereview.chromium.org/1109983003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
(right):

https://codereview.chromium.org/1109983003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:250:
enter: '$role'
On 2015/04/28 18:47:40, dmazzoni wrote:
> Should this one have describe_index too?

No afaik because these are "normal" listitems (e.g. children of ul).

[dmazzoni, 2015-04-28 19:13:26]

lgtm

https://codereview.chromium.org/1109983003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
(right):

https://codereview.chromium.org/1109983003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:250:
enter: '$role'
On 2015/04/28 19:06:33, David Tseng wrote:
> On 2015/04/28 18:47:40, dmazzoni wrote:
> > Should this one have describe_index too?
> 
> No afaik because these are "normal" listitems (e.g. children of ul).

Maybe when we add support for extra verbose "help" text we can add that there.
It seems potentially useful but maybe too verbose to announce by default for a
typical list.

[David Tseng, 2015-04-28 19:59:54]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2015-04-28 20:00:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1109983003/60001

[David Tseng, 2015-04-28 20:02:52]

https://codereview.chromium.org/1109983003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
(right):

https://codereview.chromium.org/1109983003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:250:
enter: '$role'
On 2015/04/28 19:13:26, dmazzoni wrote:
> On 2015/04/28 19:06:33, David Tseng wrote:
> > On 2015/04/28 18:47:40, dmazzoni wrote:
> > > Should this one have describe_index too?
> > 
> > No afaik because these are "normal" listitems (e.g. children of ul).
> 
> Maybe when we add support for extra verbose "help" text we can add that there.
> It seems potentially useful but maybe too verbose to announce by default for a
> typical list.

Agreed on verbosity. I think most screen readers don't do this because listItems
of this type are not atomic. Also, the list prefix should depend on the
parenting list; if it's an ordered list or not.

[commit-bot: I haz the power, 2015-04-28 20:53:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-28 20:55:37]

Patchset 4 (id:??) landed as
https://crrev.com/5ed119b3af7ab4322e6f36adccbc67680b012857
Cr-Commit-Position: refs/heads/master@{#327362}