Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1109953003: Check in animation policy extension. (Closed)

Created:
5 years, 7 months ago by dmazzoni
Modified:
5 years, 7 months ago
Reviewers:
je_julie(Not used)
CC:
chromium-reviews, extensions-reviews_chromium.org, je_julie(Not used), plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@update_versions
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check in animation policy extension. It's on the web store here: https://chrome.google.com/webstore/detail/animation-policy/ncigbofjfbodhkaffojakplpmnleeoee BUG=3690 NOTRY=true Committed: https://crrev.com/cbcd3c15c2edcb9cf9c7fda3ee0b09201ea868ea Cr-Commit-Position: refs/heads/master@{#327563}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -0 lines) Patch
M ui/accessibility/extensions/accessibility_extensions.gyp View 2 chunks +28 lines, -0 lines 0 comments Download
A ui/accessibility/extensions/animation/animation.png View Binary file 0 comments Download
A ui/accessibility/extensions/animation/manifest.json View 1 chunk +15 lines, -0 lines 0 comments Download
A ui/accessibility/extensions/animation/popup.html View 1 chunk +52 lines, -0 lines 0 comments Download
A ui/accessibility/extensions/animation/popup.js View 1 chunk +44 lines, -0 lines 3 comments Download
M ui/accessibility/extensions/strings/accessibility_extensions_strings.grd View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dmazzoni
Thanks for this contribution! I updated the strings and set them up for translation.
5 years, 7 months ago (2015-04-28 19:00:07 UTC) #2
je_julie(Not used)
lgtm! Thanks a lot! I'm very happy with that. https://codereview.chromium.org/1109953003/diff/1/ui/accessibility/extensions/animation/popup.js File ui/accessibility/extensions/animation/popup.js (right): https://codereview.chromium.org/1109953003/diff/1/ui/accessibility/extensions/animation/popup.js#newcode9 ui/accessibility/extensions/animation/popup.js:9: ...
5 years, 7 months ago (2015-04-29 09:15:37 UTC) #3
dmazzoni
https://codereview.chromium.org/1109953003/diff/1/ui/accessibility/extensions/animation/popup.js File ui/accessibility/extensions/animation/popup.js (right): https://codereview.chromium.org/1109953003/diff/1/ui/accessibility/extensions/animation/popup.js#newcode9 ui/accessibility/extensions/animation/popup.js:9: console.log('set policy '+': '+setting); On 2015/04/29 09:15:37, je_julie wrote: ...
5 years, 7 months ago (2015-04-29 20:06:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109953003/1
5 years, 7 months ago (2015-04-29 20:07:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 21:32:45 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 21:34:29 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cbcd3c15c2edcb9cf9c7fda3ee0b09201ea868ea
Cr-Commit-Position: refs/heads/master@{#327563}

Powered by Google App Engine
This is Rietveld 408576698