Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1715)

Unified Diff: base/message_loop/message_loop_proxy.h

Issue 1109933004: Adding a comment for MessageLoopProxy deprecation in message_loop_proxy.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop/message_loop_proxy.h
diff --git a/base/message_loop/message_loop_proxy.h b/base/message_loop/message_loop_proxy.h
index 88eeac4ee6d50a55ffefaa560864c59d1241b9f8..5b56d3acee69eb1c3b137e36872e3dd25da578c0 100644
--- a/base/message_loop/message_loop_proxy.h
+++ b/base/message_loop/message_loop_proxy.h
@@ -10,6 +10,18 @@
#include "base/memory/ref_counted.h"
#include "base/single_thread_task_runner.h"
+// MessageLoopProxy is depreciated. Code should prefer to depend on TaskRunner
Ryan Sleevi 2015/05/05 01:09:38 s/depreciated/deprecated/
anujsharma 2015/05/05 03:27:02 Done.
+// (or the various specializations) for passing task runners around, and should
+// use ThreadTaskRunnerHandle::Get() to get the thread's associated task runner.
+//
+// See http://crbug.com/391045 for more details.
+// Example for these changes:-
Lei Zhang 2015/05/05 00:40:31 There's an extra '-' here.
anujsharma 2015/05/05 03:27:02 Removed!!
+//
+// MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get()
+// scoped_refptr<base::MessageLoopProxy> ->
+// scoped_refptr<SingleThreadTaskRunner>
Ryan Sleevi 2015/05/05 01:09:38 This is, of course, wrong - missing a base:: quali
anujsharma 2015/05/05 03:27:02 Done.
+// MessageLoopProxy -> SingleThreadTaskRunner
+
namespace base {
// This class provides a thread-safe refcounted interface to the Post* methods
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698