Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: base/message_loop/message_loop_proxy.h

Issue 1109933004: Adding a comment for MessageLoopProxy deprecation in message_loop_proxy.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed nit Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_MESSAGE_LOOP_MESSAGE_LOOP_PROXY_H_ 5 #ifndef BASE_MESSAGE_LOOP_MESSAGE_LOOP_PROXY_H_
6 #define BASE_MESSAGE_LOOP_MESSAGE_LOOP_PROXY_H_ 6 #define BASE_MESSAGE_LOOP_MESSAGE_LOOP_PROXY_H_
7 7
8 #include "base/base_export.h" 8 #include "base/base_export.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "base/single_thread_task_runner.h" 11 #include "base/single_thread_task_runner.h"
12 12
13 // MessageLoopProxy is deprecated. Code should prefer to depend on TaskRunner
14 // (or the various specializations) for passing task runners around, and should
15 // use ThreadTaskRunnerHandle::Get() to get the thread's associated task runner.
16 //
17 // See http://crbug.com/391045 for more details.
18 // Example for these changes:
19 //
20 // base::MessageLoopProxy::current() -> base::ThreadTaskRunnerHandle::Get()
21 // scoped_refptr<base::MessageLoopProxy> ->
22 // scoped_refptr<base::SingleThreadTaskRunner>
23 // base::MessageLoopProxy -> base::SingleThreadTaskRunner
24
13 namespace base { 25 namespace base {
14 26
15 // This class provides a thread-safe refcounted interface to the Post* methods 27 // This class provides a thread-safe refcounted interface to the Post* methods
16 // of a message loop. This class can outlive the target message loop. 28 // of a message loop. This class can outlive the target message loop.
17 // MessageLoopProxy objects are constructed automatically for all MessageLoops. 29 // MessageLoopProxy objects are constructed automatically for all MessageLoops.
18 // So, to access them, you can use any of the following: 30 // So, to access them, you can use any of the following:
19 // Thread::message_loop_proxy() 31 // Thread::message_loop_proxy()
20 // MessageLoop::current()->message_loop_proxy() 32 // MessageLoop::current()->message_loop_proxy()
21 // MessageLoopProxy::current() 33 // MessageLoopProxy::current()
22 // 34 //
23 // TODO(akalin): Now that we have the *TaskRunner interfaces, we can 35 // TODO(akalin): Now that we have the *TaskRunner interfaces, we can
24 // merge this with MessageLoopProxyImpl. 36 // merge this with MessageLoopProxyImpl.
25 class BASE_EXPORT MessageLoopProxy : public SingleThreadTaskRunner { 37 class BASE_EXPORT MessageLoopProxy : public SingleThreadTaskRunner {
26 public: 38 public:
27 // Gets the MessageLoopProxy for the current message loop, creating one if 39 // Gets the MessageLoopProxy for the current message loop, creating one if
28 // needed. 40 // needed.
29 static scoped_refptr<MessageLoopProxy> current(); 41 static scoped_refptr<MessageLoopProxy> current();
30 42
31 protected: 43 protected:
32 MessageLoopProxy(); 44 MessageLoopProxy();
33 ~MessageLoopProxy() override; 45 ~MessageLoopProxy() override;
34 }; 46 };
35 47
36 } // namespace base 48 } // namespace base
37 49
38 #endif // BASE_MESSAGE_LOOP_MESSAGE_LOOP_PROXY_H_ 50 #endif // BASE_MESSAGE_LOOP_MESSAGE_LOOP_PROXY_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698