Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1109933003: Fix build warning: 'this' pointer cannot be null in well-defined C++ code; comparison may be assume… (Closed)

Created:
5 years, 7 months ago by dshwang
Modified:
5 years, 7 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix build warning: 'this' pointer cannot be null in well-defined C++ code; comparison may be assumed to always evaluate to true [-Wtautological-undefined-compare] Committed: https://skia.googlesource.com/skia/+/30297c53bd233a6d9af7b422ad8a17912f1ef5e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/core/SkPath.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
dshwang
could you review remained build warning?
5 years, 7 months ago (2015-04-30 06:19:14 UTC) #2
reed1
lgtm
5 years, 7 months ago (2015-04-30 12:54:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109933003/1
5 years, 7 months ago (2015-04-30 12:54:15 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 14:47:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/30297c53bd233a6d9af7b422ad8a17912f1ef5e6

Powered by Google App Engine
This is Rietveld 408576698