Issue 11099069: Roll grit-i18n 74:75

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11099069: Roll grit-i18n 74:75 (Closed)

Created:
8 years, 2 months ago by Sergey Ulanov

Modified:
8 years, 2 months ago

Reviewers:
Jói

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Roll grit-i18n 74:75 This adds -f option in grit_info.py to specify resources_ids file. TBR=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161367

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jói

8 years, 2 months ago (2012-10-11 18:53:10 UTC) #2

LGTM
On Oct 11, 2012 5:24 PM, <sergeyu@chromium.org> wrote:

> Reviewers: Jói,
>
> Description:
> Roll grit-i18n 74:75
>
> This adds -f option in grit_info.py to specify resources_ids file.
>
> TBR=joi@chromium.org
>
> Committed: https://src.chromium.org/**viewvc/chrome?view=rev&**
>
revision=161367<https://src.chromium.org/viewvc/chrome?view=rev&revision=161367>
>
> Please review this at
http://codereview.chromium.**org/11099069/<http://codereview.chromium.org/110...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M DEPS
>
>
> Index: DEPS
> diff --git a/DEPS b/DEPS
> index e6d59ad13800174b53414e011fc1b5**f80a117d80..**
> ce11eda91ce217e5db6c475f127540**4bd5ab69b9 100644
> --- a/DEPS
> +++ b/DEPS
> @@ -100,7 +100,7 @@ deps = {
>      (Var("googlecode_url") % "snappy") + "/trunk@63",
>
>    "src/tools/grit":
> -    (Var("googlecode_url") % "grit-i18n") + "/trunk@74",
> +    (Var("googlecode_url") % "grit-i18n") + "/trunk@75",
>
>    "src/tools/gyp":
>      (Var("googlecode_url") % "gyp") + "/trunk@1519",
>
>
>

Expand Messages | Collapse Messages