Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 11099049: Report error in APIs if type is malformed instead of crashing. Example: (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
===================================================================
--- runtime/vm/dart_api_impl.cc (revision 13496)
+++ runtime/vm/dart_api_impl.cc (working copy)
@@ -289,7 +289,11 @@
static Dart_Handle TypeToHandle(Isolate* isolate,
const char* function_name,
const AbstractType& type) {
- if (type.HasResolvedTypeClass()) {
+ if (type.IsMalformed()) {
+ const Error& error = Error::Handle(type.malformed_error());
+ return Api::NewError("%s: malformed type encountered: %s.",
+ function_name, error.ToErrorCString());
+ } else if (type.HasResolvedTypeClass()) {
const Class& cls = Class::Handle(isolate, type.type_class());
#if defined(DEBUG)
const Library& lib = Library::Handle(cls.library());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698