Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 11099044: Register parameter types for closure invocations to the backend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Disable call_test for VM. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/codegen.dart
diff --git a/lib/compiler/implementation/ssa/codegen.dart b/lib/compiler/implementation/ssa/codegen.dart
index 16081b16dc27b91592582710d33730c1e5bf7cfe..5afc86f5d63dffcf89b7768fee87c290c7cdbbae 100644
--- a/lib/compiler/implementation/ssa/codegen.dart
+++ b/lib/compiler/implementation/ssa/codegen.dart
@@ -1549,6 +1549,11 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
node);
Selector call = new Selector.callClosureFrom(node.selector);
world.registerDynamicInvocation(call.name, call);
+ // A closure can also be invoked through [HInvokeDynamicMethod] by
+ // explicitly calling the [:call:] method. Therefore, we must also
+ // register types here to let the backend invalidate wrong
+ // optimizations.
+ backend.registerDynamicInvocation(node, call, types);
}
visitInvokeStatic(HInvokeStatic node) {

Powered by Google App Engine
This is Rietveld 408576698