Slightly improved register constraints for mint add and sub.

runtime/vm/intermediate_language_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/intermediate_language.h"
 
 #include "lib/error.h"
@@ skipping 2366 matching lines @@
       summary->set_out(Location::SameAsFirstInput());
       return summary;
     }
     case Token::kADD:
     case Token::kSUB: {
       const intptr_t kNumTemps = 2;
       LocationSummary* summary =
           new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
       summary->set_in(0, Location::RequiresXmmRegister());
       summary->set_in(1, Location::RequiresXmmRegister());
-      summary->set_temp(0, Location::RegisterLocation(EAX));
-      summary->set_temp(1, Location::RegisterLocation(EDX));
+      summary->set_temp(0, Location::RequiresRegister());
+      summary->set_temp(1, Location::RequiresRegister());
       summary->set_out(Location::SameAsFirstInput());
       return summary;
     }
     default:
       UNREACHABLE();
       return NULL;
   }
 }
 
 
 void BinaryMintOpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   XmmRegister left = locs()->in(0).xmm_reg();
   XmmRegister right = locs()->in(1).xmm_reg();
 
   ASSERT(locs()->out().xmm_reg() == left);
 
   switch (op_kind()) {
     case Token::kBIT_AND: __ andpd(left, right); break;
     case Token::kBIT_OR:  __ orpd(left, right); break;
     case Token::kBIT_XOR: __ xorpd(left, right); break;
     case Token::kADD:
     case Token::kSUB: {
+      Register lo = locs()->temp(0).reg();
+      Register hi = locs()->temp(1).reg();
       Label* deopt  = compiler->AddDeoptStub(deopt_id(),
                                              kDeoptBinaryMintOp);
       Label done, overflow;
-      __ pextrd(EAX, right, Immediate(0));  // Lower half left
-      __ pextrd(EDX, right, Immediate(1));  // Upper half left
+      __ pextrd(lo, right, Immediate(0));  // Lower half left
+      __ pextrd(hi, right, Immediate(1));  // Upper half left
       __ subl(ESP, Immediate(2 * kWordSize));
       __ movq(Address(ESP, 0), left);
       if (op_kind() == Token::kADD) {
-        __ addl(Address(ESP, 0), EAX);
-        __ adcl(Address(ESP, 1 * kWordSize), EDX);
+        __ addl(Address(ESP, 0), lo);
+        __ adcl(Address(ESP, 1 * kWordSize), hi);
       } else {
-        __ subl(Address(ESP, 0), EAX);
-        __ sbbl(Address(ESP, 1 * kWordSize), EDX);
+        __ subl(Address(ESP, 0), lo);
+        __ sbbl(Address(ESP, 1 * kWordSize), hi);
       }
       __ j(OVERFLOW, &overflow);
       __ movq(left, Address(ESP, 0));
       __ addl(ESP, Immediate(2 * kWordSize));
       __ jmp(&done);
       __ Bind(&overflow);
       __ addl(ESP, Immediate(2 * kWordSize));
       __ jmp(deopt);
       __ Bind(&done);
       break;
@@ skipping 91 matching lines @@
   __ pcmpeqq(XMM0, XMM0);  // Generate all 1's.
   __ pxor(value, XMM0);
 }
 
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64