Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: dart/tools/testing/dart/test_progress.dart

Issue 11099008: Group co19 failures and test dart2dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tools/testing/dart/co19_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/test_progress.dart
diff --git a/dart/tools/testing/dart/test_progress.dart b/dart/tools/testing/dart/test_progress.dart
index 7ea2d7348ff4de445b8be83051f4660f40cfcbbb..502350ba0d5e2ec907514976a3e0241a6ee7c8f0 100644
--- a/dart/tools/testing/dart/test_progress.dart
+++ b/dart/tools/testing/dart/test_progress.dart
@@ -396,25 +396,33 @@ class BuildbotProgressIndicator extends ProgressIndicator {
}
class DiffProgressIndicator extends ColorProgressIndicator {
- Map<String, List<String>> failures = new Map<String, List<String>>();
+ Map<String, List<String>> statusToConfigs = new Map<String, List<String>>();
DiffProgressIndicator(Date startTime, bool printTiming)
: super(startTime, printTiming);
void _printFailureOutput(TestCase test) {
- List<String> configurationFailures =
- failures.putIfAbsent(test.configurationString, () => <String>[]);
- configurationFailures.add('${test.displayName}: ${test.output.result}');
+ String status = '${test.displayName}: ${test.output.result}';
+ List<String> configs =
+ statusToConfigs.putIfAbsent(status, () => <String>[]);
+ configs.add(test.configurationString);
}
void _printFailureSummary() {
- failures.forEach((key, lines) {
+ Map<String, List<String>> groupedStatuses = new Map<String, List<String>>();
+ statusToConfigs.forEach((String status, List<String> configs) {
+ configs.sort((a, b) => a.compareTo(b));
+ List<String> statuses =
+ groupedStatuses.putIfAbsent('$configs', () => <String>[]);
+ statuses.add(status);
+ });
+ groupedStatuses.forEach((String config, List<String> statuses) {
print('');
print('');
- print('$key:');
- lines.sort((a, b) => a.compareTo(b));
- for (String line in lines) {
- print(' $line');
+ print('$config:');
+ statuses.sort((a, b) => a.compareTo(b));
+ for (String status in statuses) {
+ print(' $status');
}
});
_printStatus();
« no previous file with comments | « dart/tools/testing/dart/co19_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698