Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1109883003: Revert of Mike's radial gradient CL with better float -> int. (Closed)

Created:
5 years, 8 months ago by mtklein
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Mike's radial gradient CL with better float -> int. (patchset #7 id:120001 of https://codereview.chromium.org/1109643002/) Reason for revert: compile failures. Original issue's description: > Mike's radial gradient CL with better float -> int. > > patch from issue 1072303005 at patchset 40001 (http://crrev.com/1072303005#ps40001) > > This looks quite launchable. radial_gradient3, min of 100 samples: > N5: 985µs -> 946µs > MBP: 395µs -> 279µs > > On my MBP, most of the meat looks like it's now in reading the cache and writing to dst one color at a time. Is that something we could do in float math rather than with a lookup table? > > BUG=skia: > > CQ_EXTRA_TRYBOTS=client.skia.android:Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Debug-Trybot,Test-Android-GCC-Nexus9-CPU-Denver-Arm64-Debug-Trybot > > Committed: https://skia.googlesource.com/skia/+/abf6c5cf95e921fae59efb487480e5b5081cf0ec TBR=reed@google.com,robertphillips@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/8d3e9dff3f3db3fa77c383e4cd6c47b9898a8fcd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -190 lines) Patch
M gm/gradients.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkNx.h View 4 chunks +0 lines, -14 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 5 chunks +8 lines, -81 lines 0 comments Download
M src/opts/SkNx_neon.h View 2 chunks +0 lines, -44 lines 0 comments Download
M src/opts/SkNx_sse.h View 2 chunks +0 lines, -40 lines 0 comments Download
M tests/SkNxTest.cpp View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Mike's radial gradient CL with better float -> int.
5 years, 8 months ago (2015-04-27 18:20:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109883003/1
5 years, 8 months ago (2015-04-27 18:21:04 UTC) #2
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 18:21:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8d3e9dff3f3db3fa77c383e4cd6c47b9898a8fcd

Powered by Google App Engine
This is Rietveld 408576698