content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java - Issue 1109863003: Revert of [Android] Stop hiding the RWHV layer subtree when hiding the widget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java

Issue 1109863003: Revert of [Android] Stop hiding the RWHV layer subtree when hiding the widget (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_android.cc ('k') | ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java

diff --git a/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java b/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java

index a5a94719881c94693f0bf2519877acd3a80b3075..bc460bf6d028469f4d529c9dfd83cecd28eae18b 100644

--- a/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java

+++ b/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java

@@ -71,8 +71,7 @@

setContentView(R.layout.content_shell_activity);

mShellManager = (ShellManager) findViewById(R.id.shell_container);

- final boolean listenToActivityState = true;

- mWindowAndroid = new ActivityWindowAndroid(this, listenToActivityState);

+ mWindowAndroid = new ActivityWindowAndroid(this);

mWindowAndroid.restoreInstanceState(savedInstanceState);

mShellManager.setWindow(mWindowAndroid);

// Set up the animation placeholder to be the SurfaceView. This disables the

@@ -184,6 +183,14 @@

}

@Override

+ protected void onStop() {

+ super.onStop();

+ ContentViewCore contentViewCore = getActiveContentViewCore();

+ if (contentViewCore != null) contentViewCore.onHide();

+ }

+ @Override

protected void onStart() {

super.onStart();