Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1109853003: [test] Remove pesky MachineCallHelper from inheritance chain. (Closed)

Created:
5 years, 8 months ago by Michael Starzinger
Modified:
5 years, 7 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Remove pesky MachineCallHelper from inheritance chain. R=titzer@chromium.org Committed: https://crrev.com/986e242976ebae2eb8e6746f9e2ae9bc34f48106 Cr-Commit-Position: refs/heads/master@{#28173}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -86 lines) Patch
M test/cctest/cctest.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 1 2 5 chunks +40 lines, -29 lines 0 comments Download
D test/cctest/compiler/graph-builder-tester.cc View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 7 months ago (2015-04-30 13:19:07 UTC) #1
titzer
lgtm
5 years, 7 months ago (2015-04-30 13:22:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109853003/40001
5 years, 7 months ago (2015-04-30 13:24:03 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-04-30 14:51:54 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 14:52:13 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/986e242976ebae2eb8e6746f9e2ae9bc34f48106
Cr-Commit-Position: refs/heads/master@{#28173}

Powered by Google App Engine
This is Rietveld 408576698