Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 110983004: IndexedDB: More database<->transaction relationship simplification (Closed)

Created:
7 years ago by jsbell
Modified:
7 years ago
Reviewers:
dgrogan
CC:
chromium-reviews, jsbell, jam, alecflett, joi+watch-content_chromium.org, darin-cc_chromium.org, cmumford, dgrogan
Visibility:
Public.

Description

IndexedDB: More database<->transaction relationship simplification A follow on to crrev.com/112293002 - replace holding an extra pointer to determine state with querying an existing member object. R=dgrogan Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242140

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -24 lines) Patch
M content/browser/indexed_db/indexed_db_database.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 1 4 chunks +2 lines, -14 lines 0 comments Download
M content/browser/indexed_db/indexed_db_transaction.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_transaction_coordinator.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_transaction_coordinator.cc View 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jsbell
dgrogan@ - please take a look?
7 years ago (2013-12-19 17:25:19 UTC) #1
dgrogan
lgtm
7 years ago (2013-12-19 18:50:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/110983004/20001
7 years ago (2013-12-19 20:19:42 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=108246
7 years ago (2013-12-20 01:38:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/110983004/20001
7 years ago (2013-12-20 01:41:59 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=108384
7 years ago (2013-12-20 08:55:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/110983004/20001
7 years ago (2013-12-20 17:54:40 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-20 19:34:25 UTC) #8
Message was sent while issue was closed. 
Change committed as 242140

Powered by Google App Engine
This is Rietveld 408576698