Grab mouse capture in the WM_POINTERDOWN message handler in the omnibox.

chrome/browser/ui/views/omnibox/omnibox_view_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/omnibox/omnibox_view_win.h"
 
 #include <algorithm>
 #include <locale>
 #include <string>
 
@@ skipping 1353 matching lines @@
   // the smaller value.
   model()->AdjustTextForCopy(sel.cpMin, IsSelectAll(), &text, &url, &write_url);
   DoCopy(text, write_url ? &url : NULL);
 }
 
 LRESULT OmniboxViewWin::OnCreate(const CREATESTRUCTW* /*create_struct*/) {
   if (base::win::IsTsfAwareRequired()) {
     // Enable TSF support of RichEdit.
     SetEditStyle(SES_USECTF, SES_USECTF);
   }
+
+  if (base::win::GetVersion() >= base::win::VERSION_WIN8) {
+    BOOL touch_mode = RegisterTouchWindow(m_hWnd, TWF_WANTPALM);
+    DCHECK(touch_mode);
+  }
   SetMsgHandled(FALSE);
   return 0;
 }
 
 void OmniboxViewWin::OnCut() {
   OnCopy();
 
   // This replace selection will have no effect (even on the undo stack) if the
   // current selection is empty.
   ReplaceSel(L"", true);
 }
 
 LRESULT OmniboxViewWin::OnGetObject(UINT message,
                                     WPARAM wparam,
                                     LPARAM lparam) {
   // This is a request for the native accessibility object.
   if (lparam == OBJID_CLIENT) {
     return LresultFromObject(IID_IAccessible, wparam,
                              native_view_host_->GetNativeViewAccessible());
   }
   return 0;
 }
 
+void OmniboxViewWin::OnDestroy() {
+  if (base::win::GetVersion() >= base::win::VERSION_WIN8)
+    UnregisterTouchWindow(m_hWnd);

[Peter Kasting, 2012/10/12 21:16:31]

Do we actually need to do this?  It seems from the MSDN docs like this is only
necessary if we want to mark the window as non-touch-friendly, it's not
something where you're required to balance your calls.

[ananta, 2012/10/12 21:34:53]

Removed this and the OnDestroy handler.

+}
+
 LRESULT OmniboxViewWin::OnImeComposition(UINT message,
                                          WPARAM wparam,
                                          LPARAM lparam) {
   if (ignore_ime_messages_) {
     // This message was sent while we're in the middle of meddling with the
     // underlying edit control.  If we handle it below, OnAfterPossibleChange()
     // can get bogus text for the edit, and rerun autocomplete, destructively
     // modifying the result set that we're in the midst of using.  For example,
     // if SetWindowTextAndCaretPos() was called due to the user clicking an
     // entry in the popup, we're in the middle of executing SetSelectedLine(),
@@ skipping 32 matching lines @@
       if (model()->user_input_in_progress())
         UpdatePopup();
 
       break;
     default:
       break;
   }
   return DefWindowProc(message, wparam, lparam);
 }
 
-LRESULT OmniboxViewWin::OnPointerDown(UINT message,
-                                      WPARAM wparam,
-                                      LPARAM lparam) {
-  if (!model()->has_focus())
-    SetFocus();
-
-  if (IS_POINTER_FIRSTBUTTON_WPARAM(wparam)) {
-    TrackMousePosition(kLeft, CPoint(GET_X_LPARAM(lparam),
-                                     GET_Y_LPARAM(lparam)));
+LRESULT OmniboxViewWin::OnTouchEvent(UINT message,
+                                     WPARAM wparam,
+                                     LPARAM lparam) {
+  // There is a bug in Windows 8 where in the generated mouse messages
+  // after touch go to the window which previously had focus. This means that
+  // if a user taps the omnibox to give it focus, we don't get the simulated
+  // WM_LBUTTONDOWN, and thus don't properly select all the text. To ensure
+  // that we get this message, we capture the mouse when the user is doing a
+  // single-point tap on an unfocused model.
+  if ((wparam == 1) && !model()->has_focus()) {
+    TOUCHINPUT point = {0};
+    if (GetTouchInputInfo(reinterpret_cast<HTOUCHINPUT>(lparam), 1,
+                          &point, sizeof(TOUCHINPUT))) {
+      if (point.dwFlags & TOUCHEVENTF_DOWN) {
+        SetFocus();

[Peter Kasting, 2012/10/12 21:16:31]

Is this SetFocus() necessary?  I thought you said we don't need this.

[ananta, 2012/10/12 21:34:53]

Good point. Artifact of the previous iteration. Will test it out before landing.

+        SetCapture();
+      } else if (point.dwFlags & TOUCHEVENTF_UP) {
+        ReleaseCapture();
+      }
+    }
   }
-
   SetMsgHandled(false);
-
-  return 0;
-}
-
-LRESULT OmniboxViewWin::OnPointerUp(UINT message, WPARAM wparam,
-                                    LPARAM lparam) {
-  SetMsgHandled(false);
-
   return 0;
 }
 
 void OmniboxViewWin::OnKeyDown(TCHAR key,
                                UINT repeat_count,
                                UINT flags) {
   delete_at_end_pressed_ = false;
 
   if (OnKeyDownAllModes(key, repeat_count, flags))
     return;
@@ skipping 194 matching lines @@
   // actually going to activate and gain focus.
   LRESULT result = DefWindowProc(WM_MOUSEACTIVATE,
                                  reinterpret_cast<WPARAM>(window),
                                  MAKELPARAM(hit_test, mouse_message));
   // Check if we're getting focus from a click.  We have to do this here rather
   // than in OnXButtonDown() since in many scenarios OnSetFocus() will be
   // reached before OnXButtonDown(), preventing us from detecting this properly
   // there.  Also in those cases, we need to already know in OnSetFocus() that
   // we should not restore the saved selection.
   if (!model()->has_focus() &&
-      ((mouse_message == WM_LBUTTONDOWN || mouse_message == WM_RBUTTONDOWN ||
-        mouse_message == WM_POINTERDOWN)) &&
+      ((mouse_message == WM_LBUTTONDOWN || mouse_message == WM_RBUTTONDOWN)) &&
       (result == MA_ACTIVATE)) {
-    DCHECK(!gaining_focus_.get());
+    // On Windows 8 in metro mode, we get two WM_MOUSEACTIVATE messages when
+    // we click on the omnibox with the mouse.
+    if (!base::win::IsMetroProcess())

[Peter Kasting, 2012/10/12 21:16:31]

Seems like it'd be better to do:

  if (gaining_focus_) {
    DCHECK(base::win::IsMetroProcess());
    return result;
  }

[ananta, 2012/10/12 21:34:53]

Done.

+      DCHECK(!gaining_focus_.get());
     gaining_focus_.reset(new ScopedFreeze(this, GetTextObjectModel()));
     // NOTE: Despite |mouse_message| being WM_XBUTTONDOWN here, we're not
     // guaranteed to call OnXButtonDown() later!  Specifically, if this is the
     // second click of a double click, we'll reach here but later call
     // OnXButtonDblClk().  Make sure |gaining_focus_| gets reset both places,
     // or we'll have visual glitchiness and then DCHECK failures.
 
     // Don't restore saved selection, it will just screw up our interaction
     // with this edit.
     saved_selection_for_focus_change_.cpMin = -1;
@@ skipping 982 matching lines @@
   return (rect.left - client_rect.left) + (client_rect.right - rect.right);
 }
 
 int OmniboxViewWin::WidthNeededToDisplay(const string16& text) const {
   // Use font_.GetStringWidth() instead of
   // PosFromChar(location_entry_->GetTextLength()) because PosFromChar() is
   // apparently buggy. In both LTR UI and RTL UI with left-to-right layout,
   // PosFromChar(i) might return 0 when i is greater than 1.
   return font_.GetStringWidth(text) + GetHorizontalMargin();
 }