Fix bug in ByteArray.subByteArray implementation for omitted length.

tests/standalone/byte_array_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Dart test program for testing native byte arrays.
 
 // Library tag to be able to run in html test framework.
 #library("ByteArrayTest.dart");
 
 #import('dart:scalarlist');
@@ skipping 60 matching lines @@
   list = new Float32List(10);
   for (int i = 0; i < list.length; i++) {
     list[i] = i + 10.0;
   }
   Expect.equals(0, list.indexOf(10.0));
   Expect.equals(5, list.indexOf(15.0));
   Expect.equals(9, list.indexOf(19.0));
   Expect.equals(-1, list.indexOf(20.0));
 }
 
+void testSubArray() {
+  var list = new Uint8List(10);
+  var array = list.asByteArray();
+  Expect.equals(0, array.subByteArray(0, 0).lengthInBytes());
+  Expect.equals(0, array.subByteArray(5, 0).lengthInBytes());
+  Expect.equals(0, array.subByteArray(10, 0).lengthInBytes());
+  Expect.equals(0, array.subByteArray(10).lengthInBytes());
+  Expect.equals(0, array.subByteArray(10, null).lengthInBytes());

[karlklose, 2012/10/11 08:18:18]

I am not sure this is what we want and since we can detect if the argument was
given, we should probably throw.

+  Expect.equals(5, array.subByteArray(0, 5).lengthInBytes());
+  Expect.equals(5, array.subByteArray(5, 5).lengthInBytes());
+  Expect.equals(5, array.subByteArray(5).lengthInBytes());
+  Expect.equals(5, array.subByteArray(5, null).lengthInBytes());
+  Expect.equals(10, array.subByteArray(0, 10).lengthInBytes());
+  Expect.equals(10, array.subByteArray(0).lengthInBytes());
+  Expect.equals(10, array.subByteArray(0, null).lengthInBytes());
+  Expect.equals(10, array.subByteArray().lengthInBytes());
+  testThrowsIndex(function) {
+    Expect.throws(function, (e) => e is IndexOutOfRangeException);
+  }
+  testThrowsIndex(() => array.subByteArray(0, -1));
+  testThrowsIndex(() => array.subByteArray(1, -1));
+  testThrowsIndex(() => array.subByteArray(10, -1));
+  testThrowsIndex(() => array.subByteArray(-1, 0));
+  testThrowsIndex(() => array.subByteArray(-1));
+  testThrowsIndex(() => array.subByteArray(-1, null));
+  testThrowsIndex(() => array.subByteArray(11, 0));
+  testThrowsIndex(() => array.subByteArray(11));
+  testThrowsIndex(() => array.subByteArray(11, null));
+  testThrowsIndex(() => array.subByteArray(6, 5));
+  Expect.throws(() => array.subByteArray(0, "5"), (e) => e is ArgumentError);
+  Expect.throws(() => array.subByteArray("0", 5), (e) => e is ArgumentError);
+  Expect.throws(() => array.subByteArray("0"), (e) => e is ArgumentError);
+  Expect.throws(() => array.subByteArray(null), (e) => e is ArgumentError);
+}
+
 main() {
   for (int i = 0; i < 2000; i++) {
     testCreateByteArray();
     testSetRange();
     testIndexOutOfRange();
     testIndexOf();
+    testSubArray();
   }
 }
+