Fix bug in ByteArray.subByteArray implementation for omitted length.

runtime/lib/byte_array.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 patch class Int8List {
   /* patch */ factory Int8List(int length) {
     return new _Int8Array(length);
   }
 
   /* patch */ factory Int8List.view(ByteArray array,
@@ skipping 1495 matching lines @@
 class _ByteArrayView implements ByteArray {
   _ByteArrayView(this._array, this._offset, this._length) {
     _rangeCheck(_array.lengthInBytes(), _offset, _length);
   }
 
   int lengthInBytes() {
     return _length;
   }
 
   ByteArray subByteArray([int start = 0, int length]) {
+    if (start is! int) throw new ArgumentError("start is not an int");
     if (length === null) {

[karlklose, 2012/10/11 08:18:18]

Use ?length here?

-      length = this.lengthInBytes();
+      length = this.lengthInBytes() - start;
+    } else if (length is! int) {
+      throw new ArgumentError("length is not an int");
     }
     return new _ByteArrayView(_array, _offset + start, length);
   }
 
   int getInt8(int byteOffset) {
     return _array._getInt8(_offset + byteOffset);
   }
   int setInt8(int byteOffset, int value) {
     return _array._setInt8(_offset + byteOffset, value);
   }
@@ skipping 878 matching lines @@
     }
     _rangeCheck(this.length, start, length);
     return _array.subByteArray(_offset + start, length);
   }
 
   static const int _BYTES_PER_ELEMENT = 8;
   final ByteArray _array;
   final int _offset;
   final int _length;
 }