Fix safesync_url handling for git.

Fix safesync_url handling for git.

Takes into account the new submodule-enabled repository layout.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161403

[szager1, 2012-10-11 19:15:42]

This may help clarify the changes:

http://code.google.com/p/chromium/wiki/UsingGit#Checking_out_LKGR

[M-A Ruel, 2012-10-11 20:53:17]

Minor nits, sorry for the delay.

https://codereview.chromium.org/11098064/diff/6001/scm.py
File scm.py (right):

https://codereview.chromium.org/11098064/diff/6001/scm.py#newcode405
scm.py:405: git_svn_rev = GIT.Capture(['svn', 'find-rev', 'r' + str(rev)],
Please align at +4, like the rest of the file.

https://codereview.chromium.org/11098064/diff/6001/scm.py#newcode409
scm.py:409: output = GIT.Capture(['rev-list', '--ancestry-path', '--reverse',
Same

https://codereview.chromium.org/11098064/diff/6001/scm.py#newcode410
scm.py:410: "--grep='SVN changes up to revision [0-9]*'",
You could specify
'--grep', 'SVN changes up to revision [0-9]*',

the reason I'm saying that is because of quoting on Windows and in general I
prefer the dual args form to the = form

https://codereview.chromium.org/11098064/diff/6001/scm.py#newcode420
scm.py:420: raise gclient_utils.Error(sha1)
That's a funky way to pass out of band information. In theory, using two return
value would be cleaner but that would mean updating all the callers. So I'll let
it go for now.

[szager, 2012-10-11 21:00:43]

https://codereview.chromium.org/11098064/diff/6001/scm.py
File scm.py (right):

https://codereview.chromium.org/11098064/diff/6001/scm.py#newcode405
scm.py:405: git_svn_rev = GIT.Capture(['svn', 'find-rev', 'r' + str(rev)],
On 2012/10/11 20:53:17, Marc-Antoine Ruel wrote:
> Please align at +4, like the rest of the file.

Done.

https://codereview.chromium.org/11098064/diff/6001/scm.py#newcode409
scm.py:409: output = GIT.Capture(['rev-list', '--ancestry-path', '--reverse',
On 2012/10/11 20:53:17, Marc-Antoine Ruel wrote:
> Same

Done.

https://codereview.chromium.org/11098064/diff/6001/scm.py#newcode410
scm.py:410: "--grep='SVN changes up to revision [0-9]*'",
On 2012/10/11 20:53:17, Marc-Antoine Ruel wrote:
> You could specify
> '--grep', 'SVN changes up to revision [0-9]*',
> 
> the reason I'm saying that is because of quoting on Windows and in general I
> prefer the dual args form to the = form

Done.

[M-A Ruel, 2012-10-11 21:06:14]

lgtm with pedanticness compliance.

https://codereview.chromium.org/11098064/diff/9002/scm.py
File scm.py (right):

https://codereview.chromium.org/11098064/diff/9002/scm.py#newcode405
scm.py:405: git_svn_rev = GIT.Capture(['svn', 'find-rev', 'r' + str(rev)],
git_svn_rev = GIT.Capture(
    ['svn', 'find-rev', 'r' + str(rev)], cwd=cwd).rstrip()

and yes, I'm pedantic about it. :)

https://codereview.chromium.org/11098064/diff/9002/scm.py#newcode409
scm.py:409: output = GIT.Capture(['rev-list', '--ancestry-path', '--reverse',
same