Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1582)

Issue 11098057: Turn on LevelDB logging (Closed)

Created:
8 years, 2 months ago by dgrogan
Modified:
8 years, 2 months ago
Reviewers:
jsbell
CC:
chromium-reviews, alecflett
Visibility:
Public.

Description

Turn on LevelDB logging This will help us diagnose corruption in the wild. BUG=140543 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162016

Patch Set 1 #

Patch Set 2 : change to ChromiumLogger #

Patch Set 3 : Remove gettid and use windows-safe functions where necessary #

Patch Set 4 : Add test and debug logging #

Patch Set 5 : sync to ToT, README, cleanup #

Total comments: 2

Patch Set 6 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -15 lines) Patch
M content/browser/in_process_webkit/indexed_db_browsertest.cc View 1 2 3 4 5 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/leveldatabase/README.chromium View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/leveldatabase/chromium_logger.h View 1 2 3 4 1 chunk +93 lines, -0 lines 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 1 2 4 2 chunks +9 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dgrogan
Josh, could you review this? It should probably wait to land until an updated leveldb ...
8 years, 2 months ago (2012-10-11 23:44:33 UTC) #1
jsbell
lgtm http://codereview.chromium.org/11098057/diff/16002/content/browser/in_process_webkit/indexed_db_browsertest.cc File content/browser/in_process_webkit/indexed_db_browsertest.cc (right): http://codereview.chromium.org/11098057/diff/16002/content/browser/in_process_webkit/indexed_db_browsertest.cc#newcode255 content/browser/in_process_webkit/indexed_db_browsertest.cc:255: // Converted pyauto tests begin here. What is ...
8 years, 2 months ago (2012-10-11 23:58:05 UTC) #2
dgrogan
http://codereview.chromium.org/11098057/diff/16002/content/browser/in_process_webkit/indexed_db_browsertest.cc File content/browser/in_process_webkit/indexed_db_browsertest.cc (right): http://codereview.chromium.org/11098057/diff/16002/content/browser/in_process_webkit/indexed_db_browsertest.cc#newcode255 content/browser/in_process_webkit/indexed_db_browsertest.cc:255: // Converted pyauto tests begin here. On 2012/10/11 23:58:05, ...
8 years, 2 months ago (2012-10-12 01:41:30 UTC) #3
jsbell
> Just makes finding the end of the "regular" browser tests easier so I know ...
8 years, 2 months ago (2012-10-12 16:41:42 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-10-15 18:38:01 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698