Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 11098030: Revert 160959 - [android_webview] Use AwContents loadUrl method instead of ContentViewCore. (Closed)

Created:
8 years, 2 months ago by acolwell GONE FROM CHROMIUM
Modified:
8 years, 2 months ago
Reviewers:
mkosiba (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Revert 160959 - [android_webview] Use AwContents loadUrl method instead of ContentViewCore. This introduces a loadUrl method on AwContents and modifies all of our test code to use that method instead of the on ContentViewCore. BUG=154558 Review URL: https://chromiumcodereview.appspot.com/11028094 TBR=mkosiba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160965

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+417 lines, -482 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 2 chunks +0 lines, -12 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewLoadUrlTest.java View 6 chunks +14 lines, -17 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java View 8 chunks +23 lines, -23 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java View 4 chunks +4 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 6 chunks +12 lines, -9 lines 0 comments Download
MM android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 83 chunks +222 lines, -253 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ClearHistoryTest.java View 2 chunks +3 lines, -6 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ClientAddMessageToConsoleTest.java View 8 chunks +11 lines, -12 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java View 6 chunks +8 lines, -9 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedErrorTest.java View 7 chunks +8 lines, -10 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ContentViewMiscTest.java View 4 chunks +4 lines, -8 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ContentViewZoomTest.java View 7 chunks +14 lines, -18 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java View 6 chunks +13 lines, -14 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/GetTitleTest.java View 5 chunks +8 lines, -9 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java View 12 chunks +21 lines, -25 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/NavigationHistoryTest.java View 7 chunks +22 lines, -24 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/UserAgentTest.java View 2 chunks +7 lines, -6 lines 0 comments Download
MM android_webview/javatests/src/org/chromium/android_webview/test/WebViewFindApisTestBase.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java View 6 chunks +22 lines, -22 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
acolwell GONE FROM CHROMIUM
8 years, 2 months ago (2012-10-09 23:07:59 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698