Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: visual_studio/NativeClientVSAddIn/buildbot_run.py

Issue 11098022: Fix reporting or errors addin building and testing (Closed) Base URL: http://nativeclient-sdk.googlecode.com/svn/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: visual_studio/NativeClientVSAddIn/buildbot_run.py
diff --git a/visual_studio/NativeClientVSAddIn/buildbot_run.py b/visual_studio/NativeClientVSAddIn/buildbot_run.py
index 6876c01e1bb787b0c25de43e3c55d513f61fb901..6a5955c14f7a14c491354de34fd0fe2151764c9a 100644
--- a/visual_studio/NativeClientVSAddIn/buildbot_run.py
+++ b/visual_studio/NativeClientVSAddIn/buildbot_run.py
@@ -34,10 +34,11 @@ def RunCommand(cmd, env=None):
# allow bat files in the current working directory to
# be executed on cygwin as they are on win32
if not os.path.dirname(cmd[0]) and os.path.exists(cmd[0]):
- cmd = './' + cmd
+ cmd[0] = './' + cmd[0]
- rtn = subprocess.call(cmd, shell=True, env=env)
+ rtn = subprocess.call(cmd, env=env)
if rtn:
+ Log("Command returned non-zero exit code: %s" % rtn)
Log('@@@STEP_FAILURE@@@')
sys.exit(1)

Powered by Google App Engine
This is Rietveld 408576698