Implement SmiToInt and DoubleToInt.

runtime/vm/intermediate_language_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/intermediate_language.h"
 
 #include "lib/error.h"
@@ skipping 1957 matching lines @@
 
   __ testq(value, Immediate(kSmiTagMask));
   __ j(NOT_ZERO, deopt);  // Deoptimize if not Smi.
   __ SmiUntag(value);
   __ cvtsi2sd(XMM0, value);
   __ movsd(FieldAddress(result, Double::value_offset()), XMM0);
   __ Drop(1);
 }
 
 
+LocationSummary* DoubleToIntegerInstr::MakeLocationSummary() const {
+  return MakeCallSummary();  // Slow case calls the method.
+}
+
+
+void DoubleToIntegerInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
+  Register result = locs()->out().reg();
+  ASSERT(result == RAX);
+  Register value_obj = RBX;
+  XmmRegister value_double = XMM0;
+  __ movq(value_obj, Address(RSP, 0));
+  __ movsd(value_double, FieldAddress(value_obj, Double::value_offset()));
+  __ cvttsd2siq(result, value_double);

[Florian Schneider, 2012/10/09 11:13:58]

Please make sure that the tests cover the corner cases like NaN and +/-Infinity.

[srdjan, 2012/10/09 21:23:04]

Yes, this is covered in arithmetic_test.dart (throw exception).

+  // Overflow is signalled with minint.
+  Label do_call, done;
+  // Check for overflow and that it fits into Smi.
+  __ cmpq(result, Immediate(0xC000000000000000));

[cshapiro, 2012/10/09 00:59:24]

Why not use SH

 SHL result, 1
 JO <overflow>

The overflow bit is set to the XOR of the CF and the MSB.

If the value of result is ever needed you can

  RCR result, 1

to restore the MSB from the CF.  With an argument of 1 this is a single cycle
instruction.

[srdjan, 2012/10/09 21:23:04]

Done, using a temporary register to preserve result.

+  __ j(NEGATIVE, &do_call, Assembler::kNearJump);
+  __ SmiTag(result);
+  __ Drop(1);
+  __ jmp(&done);
+  __ Bind(&do_call);
+  ASSERT(instance_call()->HasICData());
+  const ICData& ic_data = *instance_call()->ic_data();
+  ASSERT((ic_data.NumberOfChecks() == 1));
+  const Function& target = Function::ZoneHandle(ic_data.GetTargetAt(0));
+
+  const intptr_t kNumberOfArguments = 1;
+  compiler->GenerateStaticCall(instance_call()->deopt_id(),
+                               instance_call()->token_pos(),
+                               target,
+                               kNumberOfArguments,
+                               Array::Handle(),  // No argument names.,

[Florian Schneider, 2012/10/09 11:13:58]

Remove extra , at the end.

[srdjan, 2012/10/09 21:23:04]

Done.

+                               locs());
+  __ Bind(&done);
+}
+
+
 LocationSummary* PolymorphicInstanceCallInstr::MakeLocationSummary() const {
   return MakeCallSummary();
 }
 
 
 void PolymorphicInstanceCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   Label* deopt = compiler->AddDeoptStub(instance_call()->deopt_id(),
                                         kDeoptPolymorphicInstanceCallTestFail);
   if (ic_data().NumberOfChecks() == 0) {
     __ jmp(deopt);
@@ skipping 218 matching lines @@
 
 void ShiftMintOpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   UNIMPLEMENTED();
 }
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_X64