Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 1109783003: Import JSC class tests (Closed)

Created:
5 years, 8 months ago by arv (Not doing code reviews)
Modified:
5 years, 7 months ago
CC:
v8-dev, Michael Achenbach
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Import webkit class tests BUG=v8:3330 LOG=N Committed: https://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb Cr-Commit-Position: refs/heads/master@{#28115}

Patch Set 1 #

Patch Set 2 : All tests pass #

Total comments: 5

Patch Set 3 : git rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1523 lines, -57 lines) Patch
A test/webkit/class-constructor-return.js View 1 1 chunk +217 lines, -0 lines 0 comments Download
A test/webkit/class-constructor-return-expected.txt View 1 1 chunk +94 lines, -0 lines 0 comments Download
A + test/webkit/class-syntax-call.js View 1 2 chunks +16 lines, -13 lines 0 comments Download
A test/webkit/class-syntax-call-expected.txt View 1 1 chunk +16 lines, -0 lines 0 comments Download
A test/webkit/class-syntax-declaration.js View 1 1 chunk +83 lines, -0 lines 0 comments Download
A test/webkit/class-syntax-declaration-expected.txt View 1 1 chunk +43 lines, -0 lines 0 comments Download
A + test/webkit/class-syntax-default-constructor.js View 1 2 chunks +15 lines, -27 lines 0 comments Download
A test/webkit/class-syntax-default-constructor-expected.txt View 1 1 chunk +18 lines, -0 lines 0 comments Download
A test/webkit/class-syntax-expression.js View 1 1 chunk +81 lines, -0 lines 0 comments Download
A test/webkit/class-syntax-expression-expected.txt View 1 1 chunk +41 lines, -0 lines 0 comments Download
A test/webkit/class-syntax-extends.js View 1 1 chunk +111 lines, -0 lines 0 comments Download
A test/webkit/class-syntax-extends-expected.txt View 1 1 chunk +72 lines, -0 lines 0 comments Download
A test/webkit/class-syntax-name.js View 1 1 chunk +115 lines, -0 lines 0 comments Download
A test/webkit/class-syntax-name-expected.txt View 1 1 chunk +125 lines, -0 lines 0 comments Download
A test/webkit/class-syntax-prototype.js View 1 1 chunk +91 lines, -0 lines 0 comments Download
A test/webkit/class-syntax-prototype-expected.txt View 1 1 chunk +50 lines, -0 lines 0 comments Download
A + test/webkit/class-syntax-scoping.js View 1 2 chunks +14 lines, -11 lines 0 comments Download
A + test/webkit/class-syntax-scoping-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
A test/webkit/class-syntax-semicolon.js View 1 1 chunk +94 lines, -0 lines 0 comments Download
A test/webkit/class-syntax-semicolon-expected.txt View 1 1 chunk +65 lines, -0 lines 0 comments Download
A test/webkit/class-syntax-super.js View 1 1 chunk +96 lines, -0 lines 0 comments Download
A test/webkit/class-syntax-super-expected.txt View 1 1 chunk +46 lines, -0 lines 0 comments Download
M test/webkit/resources/standalone-pre.js View 1 3 chunks +17 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
arv (Not doing code reviews)
I'm not sure if we should add these but at least we should pass these ...
5 years, 8 months ago (2015-04-27 15:51:29 UTC) #2
arv (Not doing code reviews)
wip
5 years, 8 months ago (2015-04-27 22:45:58 UTC) #3
arv (Not doing code reviews)
All tests pass
5 years, 7 months ago (2015-04-28 15:51:16 UTC) #4
arv (Not doing code reviews)
All tests pass
5 years, 7 months ago (2015-04-28 15:52:27 UTC) #6
arv (Not doing code reviews)
This is based on https://codereview.chromium.org/1107203002/ The webkit tests have no copyright headers. I used the ...
5 years, 7 months ago (2015-04-28 16:03:47 UTC) #9
Dmitry Lomov (no reviews)
lgtm
5 years, 7 months ago (2015-04-28 16:07:14 UTC) #10
arv (Not doing code reviews)
git rebase
5 years, 7 months ago (2015-04-28 16:16:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109783003/80001
5 years, 7 months ago (2015-04-28 16:17:33 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 7 months ago (2015-04-28 16:42:42 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 16:42:54 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/525f7c85b9c76e1027de01fe768d910e9f091bfb
Cr-Commit-Position: refs/heads/master@{#28115}

Powered by Google App Engine
This is Rietveld 408576698