Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1109773003: Revert of Stop closing batch prematurely (Closed)

Created:
5 years, 8 months ago by joshualitt
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@atdfopt3
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Stop closing batch prematurely (patchset #4 id:60001 of https://codereview.chromium.org/1092403002/) Reason for revert: breaking windows bots Original issue's description: > In this CL we stop closing batches prematurely, and only close immediately before a flush. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/db3ce12c810ead7b76faa784e7293197aca0d9f1 TBR=bsalomon@google.com,robertphillips@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/8a0a16d0a5e684e22cc3464642bc03bf341149a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -51 lines) Patch
M src/gpu/GrInOrderDrawBuffer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrTargetCommands.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/gpu/GrTargetCommands.cpp View 12 chunks +16 lines, -40 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
joshualitt
Created Revert of Stop closing batch prematurely
5 years, 8 months ago (2015-04-27 18:18:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109773003/1
5 years, 8 months ago (2015-04-27 18:19:23 UTC) #2
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 18:19:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8a0a16d0a5e684e22cc3464642bc03bf341149a8

Powered by Google App Engine
This is Rietveld 408576698