Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1109773002: [turbofan] Add SimplifiedOperator::Allocate operator. (Closed)

Created:
5 years, 8 months ago by Michael Starzinger
Modified:
5 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add SimplifiedOperator::Allocate operator. This introduces a simplified allocation operator which can be used to model inline allocations in TurboFan. It is currently used for context allocations, but still disabled because change lowering introduces floating allocations outside the effect chain that interfere. R=bmeurer@chromium.org Committed: https://crrev.com/d6945db703c56ce821f764035fd31cb3a29e9e10 Cr-Commit-Position: refs/heads/master@{#28195}

Patch Set 1 #

Patch Set 2 : Fix tests for ARM. #

Total comments: 6

Patch Set 3 : Addressed comments. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -3 lines) Patch
M src/compiler/access-builder.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 2 3 3 chunks +132 lines, -0 lines 0 comments Download
M src/compiler/linkage.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 3 4 chunks +26 lines, -3 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 3 chunks +37 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Starzinger
5 years, 8 months ago (2015-04-27 12:53:52 UTC) #1
Benedikt Meurer
General direction looks good. Not sure if we want to work on that before we ...
5 years, 8 months ago (2015-04-28 08:24:24 UTC) #2
Michael Starzinger
https://codereview.chromium.org/1109773002/diff/20001/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/1109773002/diff/20001/src/compiler/js-typed-lowering.cc#newcode1088 src/compiler/js-typed-lowering.cc:1088: // TODO(mstarzinger): This is weird! Make kFinish not require ...
5 years, 7 months ago (2015-04-30 07:53:51 UTC) #3
Benedikt Meurer
LGTM
5 years, 7 months ago (2015-05-04 10:54:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109773002/60001
5 years, 7 months ago (2015-05-04 11:19:56 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-04 12:07:17 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 12:07:28 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d6945db703c56ce821f764035fd31cb3a29e9e10
Cr-Commit-Position: refs/heads/master@{#28195}

Powered by Google App Engine
This is Rietveld 408576698