Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1109763002: [turbofan] Treat uninitialized source positions as unknown. (Closed)

Created:
5 years, 8 months ago by titzer
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Treat uninitialized source positions as unknown. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/8cc7e70098d5ca968585ca4d8cb68f987fafa7a7 Cr-Commit-Position: refs/heads/master@{#28399}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -48 lines) Patch
M src/compiler/code-generator.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M src/compiler/instruction.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 12 chunks +0 lines, -24 lines 0 comments Download
M src/compiler/source-position.h View 1 2 chunks +2 lines, -8 lines 0 comments Download
M src/compiler/source-position.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
titzer
5 years, 8 months ago (2015-04-27 11:35:50 UTC) #1
Michael Starzinger
LGTM.
5 years, 7 months ago (2015-04-29 11:57:56 UTC) #2
titzer
On 2015/04/29 11:57:56, Michael Starzinger wrote: > LGTM. If there are no objections from danno, ...
5 years, 7 months ago (2015-05-11 11:26:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109763002/20001
5 years, 7 months ago (2015-05-13 15:07:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109763002/40001
5 years, 7 months ago (2015-05-13 15:43:44 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-13 16:08:10 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 16:08:19 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8cc7e70098d5ca968585ca4d8cb68f987fafa7a7
Cr-Commit-Position: refs/heads/master@{#28399}

Powered by Google App Engine
This is Rietveld 408576698