[turbofan] Sanitize language mode for JSStoreProperty operator.

test/unittests/compiler/js-operator-unittest.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/js-operator.h"
 #include "src/compiler/opcodes.h"
 #include "src/compiler/operator.h"
 #include "src/compiler/operator-properties.h"
 #include "test/unittests/test-utils.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
 namespace {
 
+const LanguageMode kLanguageModes[] = {SLOPPY, STRICT, STRONG};
+
+
 #if GTEST_HAS_COMBINE
 
 template <typename T>
 class JSOperatorTestWithLanguageModeAndParam
     : public TestWithZone,
       public ::testing::WithParamInterface<::testing::tuple<LanguageMode, T>> {
  protected:
   LanguageMode language_mode() const {
     return ::testing::get<0>(B::GetParam());
   }
@@ skipping 125 matching lines @@
 
 
 // -----------------------------------------------------------------------------
 // Shared operators with language mode.
 
 
 #if GTEST_HAS_COMBINE
 
 namespace {
 
-const LanguageMode kLanguageModes[] = {SLOPPY, STRICT, STRONG};
-
-
 struct SharedOperatorWithLanguageMode {
   const Operator* (JSOperatorBuilder::*constructor)(LanguageMode);
   IrOpcode::Value opcode;
   Operator::Properties properties;
   int value_input_count;
   int frame_state_input_count;
   int effect_input_count;
   int control_input_count;
   int value_output_count;
   int effect_output_count;
@@ skipping 19 matching lines @@
     SHARED(BitwiseXor, Operator::kNoProperties, 2, 2, 1, 1, 1, 1, 2),
     SHARED(BitwiseAnd, Operator::kNoProperties, 2, 2, 1, 1, 1, 1, 2),
     SHARED(ShiftLeft, Operator::kNoProperties, 2, 2, 1, 1, 1, 1, 2),
     SHARED(ShiftRight, Operator::kNoProperties, 2, 2, 1, 1, 1, 1, 2),
     SHARED(ShiftRightLogical, Operator::kNoProperties, 2, 2, 1, 1, 1, 1, 2),
     SHARED(Add, Operator::kNoProperties, 2, 2, 1, 1, 1, 1, 2),
     SHARED(Subtract, Operator::kNoProperties, 2, 2, 1, 1, 1, 1, 2),
     SHARED(Multiply, Operator::kNoProperties, 2, 2, 1, 1, 1, 1, 2),
     SHARED(Divide, Operator::kNoProperties, 2, 2, 1, 1, 1, 1, 2),
     SHARED(Modulus, Operator::kNoProperties, 2, 2, 1, 1, 1, 1, 2),
+    SHARED(StoreProperty, Operator::kNoProperties, 3, 2, 1, 1, 0, 1, 2),
 #undef SHARED
 };
 
 
 std::ostream& operator<<(std::ostream& os,
                          const SharedOperatorWithLanguageMode& sop) {
   return os << IrOpcode::Mnemonic(sop.opcode);
 }
 
 }  // namespace
@@ skipping 60 matching lines @@
 }
 
 
 INSTANTIATE_TEST_CASE_P(
     JSOperatorTest, JSSharedOperatorWithLanguageModeTest,
     ::testing::Combine(::testing::ValuesIn(kLanguageModes),
                        ::testing::ValuesIn(kSharedOperatorsWithLanguageMode)));
 
 #endif  // GTEST_HAS_COMBINE
 
-
-// -----------------------------------------------------------------------------
-// JSStoreProperty.
-
-
-class JSStorePropertyOperatorTest
-    : public TestWithZone,
-      public ::testing::WithParamInterface<LanguageMode> {};
-
-
-TEST_P(JSStorePropertyOperatorTest, InstancesAreGloballyShared) {
-  const LanguageMode mode = GetParam();
-  JSOperatorBuilder javascript1(zone());
-  JSOperatorBuilder javascript2(zone());
-  EXPECT_EQ(javascript1.StoreProperty(mode), javascript2.StoreProperty(mode));
-}
-
-
-TEST_P(JSStorePropertyOperatorTest, NumberOfInputsAndOutputs) {
-  JSOperatorBuilder javascript(zone());
-  const LanguageMode mode = GetParam();
-  const Operator* op = javascript.StoreProperty(mode);
-
-  EXPECT_EQ(3, op->ValueInputCount());
-  EXPECT_EQ(1, OperatorProperties::GetContextInputCount(op));
-  EXPECT_EQ(2, OperatorProperties::GetFrameStateInputCount(op));
-  EXPECT_EQ(1, op->EffectInputCount());
-  EXPECT_EQ(1, op->ControlInputCount());
-  EXPECT_EQ(8, OperatorProperties::GetTotalInputCount(op));
-
-  EXPECT_EQ(0, op->ValueOutputCount());
-  EXPECT_EQ(1, op->EffectOutputCount());
-  EXPECT_EQ(2, op->ControlOutputCount());
-}
-
-
-TEST_P(JSStorePropertyOperatorTest, OpcodeIsCorrect) {
-  JSOperatorBuilder javascript(zone());
-  const LanguageMode mode = GetParam();
-  const Operator* op = javascript.StoreProperty(mode);
-  EXPECT_EQ(IrOpcode::kJSStoreProperty, op->opcode());
-}
-
-
-TEST_P(JSStorePropertyOperatorTest, OpParameter) {
-  JSOperatorBuilder javascript(zone());
-  const LanguageMode mode = GetParam();
-  const Operator* op = javascript.StoreProperty(mode);
-  EXPECT_EQ(mode, OpParameter<LanguageMode>(op));
-}
-
-
-TEST_P(JSStorePropertyOperatorTest, Properties) {
-  JSOperatorBuilder javascript(zone());
-  const LanguageMode mode = GetParam();
-  const Operator* op = javascript.StoreProperty(mode);
-  EXPECT_EQ(Operator::kNoProperties, op->properties());
-}
-
-
-INSTANTIATE_TEST_CASE_P(JSOperatorTest, JSStorePropertyOperatorTest,
-                        ::testing::Values(SLOPPY, STRICT));
-
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8