[turbofan] Sanitize language mode for JSStoreProperty operator.

src/compiler/js-operator.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/js-operator.h"
 
 #include <limits>
 
 #include "src/base/lazy-instance.h"
 #include "src/compiler/opcodes.h"
@@ skipping 245 matching lines @@
   V(TypeOf, Operator::kPure, 1, 1)                        \
   V(InstanceOf, Operator::kNoProperties, 2, 1)            \
   V(StackCheck, Operator::kNoProperties, 0, 0)            \
   V(CreateFunctionContext, Operator::kNoProperties, 1, 1) \
   V(CreateWithContext, Operator::kNoProperties, 2, 1)     \
   V(CreateBlockContext, Operator::kNoProperties, 2, 1)    \
   V(CreateModuleContext, Operator::kNoProperties, 2, 1)   \
   V(CreateScriptContext, Operator::kNoProperties, 2, 1)
 
 
-#define CACHED_OP_LIST_WITH_LANGUAGE_MODE(V)              \
-  V(LessThan, Operator::kNoProperties, 2, 1)              \
-  V(GreaterThan, Operator::kNoProperties, 2, 1)           \
-  V(LessThanOrEqual, Operator::kNoProperties, 2, 1)       \
-  V(GreaterThanOrEqual, Operator::kNoProperties, 2, 1)    \
-  V(BitwiseOr, Operator::kNoProperties, 2, 1)             \
-  V(BitwiseXor, Operator::kNoProperties, 2, 1)            \
-  V(BitwiseAnd, Operator::kNoProperties, 2, 1)            \
-  V(ShiftLeft, Operator::kNoProperties, 2, 1)             \
-  V(ShiftRight, Operator::kNoProperties, 2, 1)            \
-  V(ShiftRightLogical, Operator::kNoProperties, 2, 1)     \
-  V(Add, Operator::kNoProperties, 2, 1)                   \
-  V(Subtract, Operator::kNoProperties, 2, 1)              \
-  V(Multiply, Operator::kNoProperties, 2, 1)              \
-  V(Divide, Operator::kNoProperties, 2, 1)                \
-  V(Modulus, Operator::kNoProperties, 2, 1)
+#define CACHED_OP_LIST_WITH_LANGUAGE_MODE(V)           \
+  V(LessThan, Operator::kNoProperties, 2, 1)           \
+  V(GreaterThan, Operator::kNoProperties, 2, 1)        \
+  V(LessThanOrEqual, Operator::kNoProperties, 2, 1)    \
+  V(GreaterThanOrEqual, Operator::kNoProperties, 2, 1) \
+  V(BitwiseOr, Operator::kNoProperties, 2, 1)          \
+  V(BitwiseXor, Operator::kNoProperties, 2, 1)         \
+  V(BitwiseAnd, Operator::kNoProperties, 2, 1)         \
+  V(ShiftLeft, Operator::kNoProperties, 2, 1)          \
+  V(ShiftRight, Operator::kNoProperties, 2, 1)         \
+  V(ShiftRightLogical, Operator::kNoProperties, 2, 1)  \
+  V(Add, Operator::kNoProperties, 2, 1)                \
+  V(Subtract, Operator::kNoProperties, 2, 1)           \
+  V(Multiply, Operator::kNoProperties, 2, 1)           \
+  V(Divide, Operator::kNoProperties, 2, 1)             \
+  V(Modulus, Operator::kNoProperties, 2, 1)            \
+  V(StoreProperty, Operator::kNoProperties, 3, 0)
 
 
 struct JSOperatorGlobalCache final {
 #define CACHED(Name, properties, value_input_count, value_output_count)  \
   struct Name##Operator final : public Operator {                        \
     Name##Operator()                                                     \
         : Operator(IrOpcode::kJS##Name, properties, "JS" #Name,          \
                    value_input_count, Operator::ZeroIfPure(properties),  \
                    Operator::ZeroIfEliminatable(properties),             \
                    value_output_count, Operator::ZeroIfPure(properties), \
@@ skipping 14 matching lines @@
               Operator::ZeroIfPure(properties),                               \
               Operator::ZeroIfEliminatable(properties), value_output_count,   \
               Operator::ZeroIfPure(properties),                               \
               Operator::ZeroIfNoThrow(properties), kLanguageMode) {}          \
   };                                                                          \
   Name##Operator<SLOPPY> k##Name##SloppyOperator;                             \
   Name##Operator<STRICT> k##Name##StrictOperator;                             \
   Name##Operator<STRONG> k##Name##StrongOperator;
   CACHED_OP_LIST_WITH_LANGUAGE_MODE(CACHED_WITH_LANGUAGE_MODE)
 #undef CACHED_WITH_LANGUAGE_MODE
-
-
-  template <LanguageMode kLanguageMode>
-  struct StorePropertyOperator final : public Operator1<LanguageMode> {
-    StorePropertyOperator()
-        : Operator1<LanguageMode>(IrOpcode::kJSStoreProperty,
-                                  Operator::kNoProperties, "JSStoreProperty", 3,
-                                  1, 1, 0, 1, 2, kLanguageMode) {}
-  };
-  StorePropertyOperator<SLOPPY> kStorePropertySloppyOperator;
-  StorePropertyOperator<STRICT> kStorePropertyStrictOperator;
 };
 
 
 static base::LazyInstance<JSOperatorGlobalCache>::type kCache =
     LAZY_INSTANCE_INITIALIZER;
 
 
 JSOperatorBuilder::JSOperatorBuilder(Zone* zone)
     : cache_(kCache.Get()), zone_(zone) {}
 
@@ skipping 76 matching lines @@
     const VectorSlotPair& feedback) {
   LoadPropertyParameters parameters(feedback);
   return new (zone()) Operator1<LoadPropertyParameters>(   // --
       IrOpcode::kJSLoadProperty, Operator::kNoProperties,  // opcode
       "JSLoadProperty",                                    // name
       2, 1, 1, 1, 1, 2,                                    // counts
       parameters);                                         // parameter
 }
 
 
-const Operator* JSOperatorBuilder::StoreProperty(LanguageMode language_mode) {
-  if (is_strict(language_mode)) {
-    return &cache_.kStorePropertyStrictOperator;
-  } else {
-    return &cache_.kStorePropertySloppyOperator;
-  }
-  UNREACHABLE();
-  return nullptr;
-}
-
-
 const Operator* JSOperatorBuilder::StoreNamed(LanguageMode language_mode,
                                               const Unique<Name>& name,
                                               PropertyICMode store_ic) {
   StoreNamedParameters parameters(language_mode, name, store_ic);
   return new (zone()) Operator1<StoreNamedParameters>(   // --
       IrOpcode::kJSStoreNamed, Operator::kNoProperties,  // opcode
       "JSStoreNamed",                                    // name
       2, 1, 1, 0, 1, 2,                                  // counts
       parameters);                                       // parameter
 }
@@ skipping 47 matching lines @@
   return new (zone()) Operator1<Unique<String>>(                 // --
       IrOpcode::kJSCreateCatchContext, Operator::kNoProperties,  // opcode
       "JSCreateCatchContext",                                    // name
       2, 1, 1, 1, 1, 2,                                          // counts
       name);                                                     // parameter
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8