Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1109733002: [turbofan] Sanitize language mode for JSStoreProperty operator. (Closed)

Created:
5 years, 8 months ago by Benedikt Meurer
Modified:
5 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Sanitize language mode for JSStoreProperty operator. R=mstarzinger@chromium.org Committed: https://crrev.com/ecf499ef8e454050d99931032f24f6f1e6b39b56 Cr-Commit-Position: refs/heads/master@{#28061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -104 lines) Patch
M src/compiler/js-operator.cc View 3 chunks +17 lines, -38 lines 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 4 chunks +4 lines, -66 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
5 years, 8 months ago (2015-04-27 09:23:17 UTC) #1
Benedikt Meurer
Hey Michi, Another followup cleanup. Please take a look. Thanks, Benedikt
5 years, 8 months ago (2015-04-27 09:23:50 UTC) #2
Michael Starzinger
LGTM.
5 years, 8 months ago (2015-04-27 09:33:12 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ecf499ef8e454050d99931032f24f6f1e6b39b56 Cr-Commit-Position: refs/heads/master@{#28061}
5 years, 8 months ago (2015-04-27 09:34:18 UTC) #4
Benedikt Meurer
5 years, 8 months ago (2015-04-27 09:34:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ecf499ef8e454050d99931032f24f6f1e6b39b56 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698