Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc

Issue 1109693003: Prevent app info dialog from making shortcuts for the Chrome component app. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
index f182d579b52435643a950a543d3a87e2f440c352..4c89f6e2eadf3a3c7aa9b3e647c16e6fa0829655 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
@@ -148,8 +148,9 @@ void AppInfoFooterPanel::CreateShortcuts() {
}
bool AppInfoFooterPanel::CanCreateShortcuts() const {
- // Ash platforms can't create shortcuts, and extensions can't have shortcuts.
- return !app_->is_extension() &&
+ // Ash platforms can't create shortcuts. Extensions and the Chrome
+ // component app can't have shortcuts.
+ return app_->id() != extension_misc::kChromeAppId && !app_->is_extension() &&
(chrome::GetHostDesktopTypeForNativeWindow(parent_window_) !=
chrome::HOST_DESKTOP_TYPE_ASH);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698