Issue 1109663002: Make Resource::switchClientsToRevalidatedResource non-virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1109663002: Make Resource::switchClientsToRevalidatedResource non-virtual (Closed)

Created:
5 years, 8 months ago by davve

Modified:
5 years, 8 months ago

Reviewers:
sof

CC:
blink-reviews, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Make Resource::switchClientsToRevalidatedResource non-virtual In https://codereview.chromium.org/1102803002/ the ImageResource::switchClientsToRevalidatedResource override function was removed. Resource::switchClientsToRevalidatedResource can now be non-virtual and made private. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194447

Created: 5 years, 8 months ago

		Unified diffs	Side-by-side diffs	Stats (+1 line, -1 line)
	M	Source/core/fetch/Resource.h	View	2 chunks	+1 line, -1 line	0 comments

Total messages: 6 (2 generated)

davve

As suggested in https://codereview.chromium.org/1102803002/diff/40001/Source/core/fetch/ImageResource.h#oldcode132 PTAL.

5 years, 8 months ago (2015-04-25 20:51:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109663002/1

5 years, 8 months ago (2015-04-26 05:46:21 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-26 05:49:50 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194447